Mail Archives: cygwin-apps/2001/11/06/13:50:35
This is a multi-part message in MIME format.
--------------060503060105040104030703
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Robert Collins wrote:
> The setup.ini should now be ok,
> the source discussion, IMO can be done separately from releasing
> setup.exe.
I've had this in my inbox for a while...it's a fix from Andy Piper's fork
of setup.exe that the XEmacs people are using.
--Chuck
2001-11-06 Charles Wilson <cwilson AT ece DOT gatech DOT edu>
* geturl.cc (get_url_to_string): clean up memory leak
(get_url_to_file): ditto
--------------060503060105040104030703
Content-Type: text/plain;
name="setup.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="setup.patch"
Index: geturl.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/geturl.cc,v
retrieving revision 2.10
diff -u -r2.10 geturl.cc
--- geturl.cc 2001/11/02 00:50:19 2.10
+++ geturl.cc 2001/11/06 18:32:10
@@ -233,6 +233,8 @@
char *rv = (char *) malloc (total_bytes);
if (NULL == rv)
{
+ if (n)
+ delete n;
log (LOG_BABBLE, "get_url_to_string(): malloc failed for rv!");
return 0;
}
@@ -246,6 +248,10 @@
bufs = tmp;
}
*rvp = 0;
+
+ if (n)
+ delete n;
+
return rv;
}
Index: geturl.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/geturl.cc,v
retrieving revision 2.10
diff -u -r2.10 geturl.cc
--- geturl.cc 2001/11/02 00:50:19 2.10
+++ geturl.cc 2001/11/06 18:46:49
@@ -233,6 +233,8 @@
char *rv = (char *) malloc (total_bytes);
if (NULL == rv)
{
+ if (n)
+ delete n;
log (LOG_BABBLE, "get_url_to_string(): malloc failed for rv!");
return 0;
}
@@ -246,6 +248,10 @@
bufs = tmp;
}
*rvp = 0;
+
+ if (n)
+ delete n;
+
return rv;
}
@@ -300,6 +306,9 @@
total_download_bytes_sofar += total_bytes;
fclose (f);
+
+ if (n)
+ delete n;
if (total_download_bytes > 0)
{
--------------060503060105040104030703--
- Raw text -