Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Message-ID: <3BE83106.4020204@ece.gatech.edu>
Date: Tue, 06 Nov 2001 13:50:46 -0500
From: Charles Wilson <cwilson AT ece DOT gatech DOT edu>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.4) Gecko/20011019 Netscape6/6.2
X-Accept-Language: en-us
MIME-Version: 1.0
To: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
CC: cygwin-apps AT cygwin DOT com
Subject: Re: whats left before releasing setup?
References: <1005048150 DOT 1442 DOT 0 DOT camel AT lifelesswks>
Content-Type: multipart/mixed;
 boundary="------------060503060105040104030703"

This is a multi-part message in MIME format.
--------------060503060105040104030703
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Robert Collins wrote:

> The setup.ini should now be ok, 
> the source discussion, IMO can be done separately from releasing
> setup.exe.


I've had this in my inbox for a while...it's a fix from Andy Piper's fork 
of setup.exe that the XEmacs people are using.

--Chuck

2001-11-06  Charles Wilson  <cwilson AT ece DOT gatech DOT edu>

	* geturl.cc (get_url_to_string): clean up memory leak
	(get_url_to_file): ditto





--------------060503060105040104030703
Content-Type: text/plain;
 name="setup.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="setup.patch"

Index: geturl.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/geturl.cc,v
retrieving revision 2.10
diff -u -r2.10 geturl.cc
--- geturl.cc	2001/11/02 00:50:19	2.10
+++ geturl.cc	2001/11/06 18:32:10
@@ -233,6 +233,8 @@
   char *rv = (char *) malloc (total_bytes);
   if (NULL == rv)
     {
+      if (n)
+        delete n;
       log (LOG_BABBLE, "get_url_to_string(): malloc failed for rv!");
       return 0;
     }
@@ -246,6 +248,10 @@
       bufs = tmp;
     }
   *rvp = 0;
+
+  if (n)
+    delete n;
+
   return rv;
 }
 
Index: geturl.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/geturl.cc,v
retrieving revision 2.10
diff -u -r2.10 geturl.cc
--- geturl.cc	2001/11/02 00:50:19	2.10
+++ geturl.cc	2001/11/06 18:46:49
@@ -233,6 +233,8 @@
   char *rv = (char *) malloc (total_bytes);
   if (NULL == rv)
     {
+      if (n)
+        delete n;
       log (LOG_BABBLE, "get_url_to_string(): malloc failed for rv!");
       return 0;
     }
@@ -246,6 +248,10 @@
       bufs = tmp;
     }
   *rvp = 0;
+
+  if (n)
+    delete n;
+
   return rv;
 }
 
@@ -300,6 +306,9 @@
   total_download_bytes_sofar += total_bytes;
 
   fclose (f);
+
+  if (n)
+    delete n;
 
   if (total_download_bytes > 0)
     {

--------------060503060105040104030703--