From patchwork Mon Jun 10 20:09:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 91833 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 57C90385DDD1 for ; Mon, 10 Jun 2024 20:10:01 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id B98E4385DDC4 for ; Mon, 10 Jun 2024 20:09:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B98E4385DDC4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B98E4385DDC4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718050175; cv=none; b=WzASI9lDhimHl+NEXMGsnkRJvtRjG9A2eyQrg0BW2gY7aHz+pkL1pqrCVx+ErCNDZmxbryF2EahnTOLfQ4IX2wTiEGpqUs1+rV9FL0ENvvtvHR0QDUpOxC8xMp2mmjdShlR3qHDaTfAjpe0J5916qtm9mR7H0yRJA+OOjgkdCXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718050175; c=relaxed/simple; bh=iwwXwDydgU4wDaYgH4AVHLvi4vpxP/f+V2gAeBXcxxE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=SVjCM5IlxPtwJYEHIcxSAGNE6GS064cHcbMQBlZRCLzTPg0pZ7pmhqNzNstJ2WHiNqYBZdiQwqaCCV0E7GCoU2ZMYcocyywEZagzZiRhvTLM+i77wUbg+ZthKc1mnykxFsiltYTnXmfrSckq7hMthxHCyCC9068z+F7F20q/8Tk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id B3690A0311; Mon, 10 Jun 2024 22:09:31 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uOJ31u4xoyby; Mon, 10 Jun 2024 22:09:31 +0200 (CEST) Received: from begin (aamiens-653-1-111-57.w83-192.abo.wanadoo.fr [83.192.234.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 885E6A0316; Mon, 10 Jun 2024 22:09:31 +0200 (CEST) Received: from samy by begin with local (Exim 4.97) (envelope-from ) id 1sGlKd-00000002aKm-0PLo; Mon, 10 Jun 2024 22:09:31 +0200 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd,commited 1/4] hurd: Fix lsetxattr return value Date: Mon, 10 Jun 2024 22:09:27 +0200 Message-ID: <20240610200930.616306-2-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240610200930.616306-1-samuel.thibault@ens-lyon.org> References: <20240610200930.616306-1-samuel.thibault@ens-lyon.org> MIME-Version: 1.0 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org The manpage says that lsetxattr returns 0 on success, like setxattr. --- sysdeps/mach/hurd/lsetxattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/mach/hurd/lsetxattr.c b/sysdeps/mach/hurd/lsetxattr.c index 3f5d335a1a..49487f78fb 100644 --- a/sysdeps/mach/hurd/lsetxattr.c +++ b/sysdeps/mach/hurd/lsetxattr.c @@ -32,5 +32,5 @@ lsetxattr (const char *path, const char *name, const void *value, size_t size, return -1; err = _hurd_xattr_set (port, name, value, size, flags); __mach_port_deallocate (__mach_task_self (), port); - return err ? __hurd_fail (err) : size; + return __hurd_fail (err); }