From patchwork Thu Dec 5 01:04:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 102450 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0FEF3858D35 for ; Thu, 5 Dec 2024 01:08:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0FEF3858D35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=j4+VjzwR X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by sourceware.org (Postfix) with ESMTPS id 2B9363858D38 for ; Thu, 5 Dec 2024 01:05:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B9363858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2B9363858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733360717; cv=none; b=IE9C76P6U8lZsFm/qtMAg7dHqA6p2EdiVwxaNdwFwrh/+D9dmY3E0VEQVxH871BmhB0iBfjscs91Tp/5+UDN6LsXBB3bSW/miTPNLiiIr4/5coUgGJLH4lAlvOm0ysaX1XJQdWSWiBNzSumAQ7NV462vv38n5akXCXxp94zaFM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733360717; c=relaxed/simple; bh=X+aMHT1BBwjzkP0XLfnVVwAdRXKMwtTVHw4k0HHan3c=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=k+08R+KLd08NiU4UI7a2pGP/NFePsCezQCKHV4ZYMY5eYa2H1XQ5cbhASXjKC6Iv0WuUBR4nkU2520LS7lCl/Y375dwgPjt8agrOL67jZYEbEFDlU3Ek370x9aujlNfdp3yic0iI1EIsK9+riAOnysCK3cjZjXHiIm/eWxeY6WA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2B9363858D38 Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-e39f43344c5so582490276.1 for ; Wed, 04 Dec 2024 17:05:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733360716; x=1733965516; darn=sourceware.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=QX0G7Kk5F6mHEG8v/kdbdCgTh51YU1viDO+L4pGrhbw=; b=j4+VjzwRKQEnk6CPHLIeIz7hz30hcOg773tVKbEGdiCOPxQWDM1uJfvc5Ujps9Rthz mJdpWSraObehaRRqhZNeBYbt2wtdekP/Sm4L7RXE0e0u4U39aSJnQu33uu8RK3zmRSxY pABx+a5OADIItgP9dUpYhHjQQRvA879ifKVq43Yvp4jJijtg9RY5Ulu0y4M6EmjYY7Pz iLr4qqrWZYJDvdkhZ2za2oFPYly4thCa/yONoeS1Uof+MQSqsPjVpeyIziRjzjZN7BDQ GStsetbA9OSFEmBq6W69o+lA/zjDB5QuVi1VfVxVbRfgCovBfmEHEp/aZCl6hsaIh7ax f1rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733360716; x=1733965516; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QX0G7Kk5F6mHEG8v/kdbdCgTh51YU1viDO+L4pGrhbw=; b=scBwid2yinJw7PKKYk344rufJU9EH1eRFTgfPFumcFGv82upFqNcfIdjm8faeeqkTY Bdavbp53+DG/Ksb7zPeVcXOyOAtNXQuQ+ETq19K21GBQdF+2uwWVDPV1B+pPSHdPFqmP R38tR4c3SrnO+cHbyK0EBmfuftdSHyifMHk3tCtHm8MLC3dV2RKCRIwgvEy1YDYAGtjV WcROIvegMr9gAlsMG8v0EGnDMfuyY7iTtbmZkbPuTTveLGHrarVv9aaUIqXywFmBqexI dsctHXUogzU9LYOtm535zvgU1+RSw4SpY2LqODrloM48oEnBR8MarsE0eTqhIkwpbjel CBAQ== X-Gm-Message-State: AOJu0Yw2YUfBBzO7mdhBib7jK83IZikSe557fWkfbLQEJv4ZRrNZRtx2 Z3sztMDOrVraRjvrniMsyZKDZ/ka9Td5zLGYZwp6PDa+mTZBkWGu3OILmtkMvjPr+7OYAFHQIf1 mMfBWl0jR3TjtNZ66vGiXykf4OWMtriHqSqlMcLfZGw4= X-Gm-Gg: ASbGnctXnxo8zNqycJLiRGcv6eu1R6ZqslAyzqnmw+dd0NR9ykgDWRleluW885S3Ztn NeCQf1IyT4LAzGZPiLVZUKKQCoG7yjmU= X-Google-Smtp-Source: AGHT+IHjeo9HMIHSDCUxjYAJ8TXJvlhIpCHySPVR8VBXmXDyU4nxWtqvrTuV1tmsLBM0m8YqNshlnEd4Ei+Q1G5EIn8= X-Received: by 2002:a05:690c:25c4:b0:6ee:4eae:5551 with SMTP id 00721157ae682-6efad19c1bfmr118782327b3.21.1733360716342; Wed, 04 Dec 2024 17:05:16 -0800 (PST) MIME-Version: 1.0 From: "H.J. Lu" Date: Thu, 5 Dec 2024 09:04:40 +0800 Message-ID: Subject: [PATCH] math: Exclude internal math symbols for tests [BZ #32414] To: GNU C Library X-Spam-Status: No, score=-3016.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Since internal tests don't have access to internal symbols in libm, exclude them for internal tests. Also make tst-strtod5 and tst-strtod5i depend on $(libm) to support older versions of GCC which can't inline copysign family functions. This fixes BZ #32414. From 95d472527e145a50f3f8c9d4b7e689059c95652a Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 5 Dec 2024 08:39:44 +0800 Subject: [PATCH] math: Exclude internal math symbols for tests [BZ #32414] Since internal tests don't have access to internal symbols in libm, exclude them for internal tests. Also make tst-strtod5 and tst-strtod5i depend on $(libm) to support older versions of GCC which can't inline copysign family functions. This fixes BZ #32414. Signed-off-by: H.J. Lu --- include/math.h | 5 ++++- stdlib/Makefile | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/math.h b/include/math.h index fa11a710a6..035fd160ff 100644 --- a/include/math.h +++ b/include/math.h @@ -130,7 +130,10 @@ fabsf128 (_Float128 x) } # endif -# if !(defined __FINITE_MATH_ONLY__ && __FINITE_MATH_ONLY__ > 0) + +/* NB: Internal tests don't have access to internal symbols. */ +# if !IS_IN (testsuite_internal) \ + && !(defined __FINITE_MATH_ONLY__ && __FINITE_MATH_ONLY__ > 0) # ifndef NO_MATH_REDIRECT /* Declare some functions for use within GLIBC. Compilers typically inline those functions as a single instruction. Use an asm to diff --git a/stdlib/Makefile b/stdlib/Makefile index c4c2f7fa96..370cfa57aa 100644 --- a/stdlib/Makefile +++ b/stdlib/Makefile @@ -609,6 +609,8 @@ $(objpfx)bug-strtod2: $(libm) $(objpfx)tst-strtod-round: $(libm) $(objpfx)tst-tininess: $(libm) $(objpfx)tst-strtod-underflow: $(libm) +$(objpfx)tst-strtod5: $(libm) +$(objpfx)tst-strtod5i: $(libm) $(objpfx)tst-strtod6: $(libm) $(objpfx)tst-strtod-nan-locale: $(libm) $(objpfx)tst-strtod-nan-sign: $(libm) -- 2.47.1