X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=1SaB44s5s44iYu4tnf4euOtgADI11yA/LHrk4tXk1Q4=; b=svADglkxChKg6xs9gQPOmySezLyUfejLQkN9bQ4ao4E7xTV/ALhlPR1cqziGF4BJA7 /fvPqxRVGYuAR+1wLAjYad/VxN3aUtClE8+4K2LTZRIcHhmp6oY3enfGn5IS3+3pX74n CJelVvfH+Jpup8AWLuv/Ri42eEONHQNsrT/SKQ47BG4odvFcnLPJnm2w/KVYpQf1lKab lOp/IXnuPa14TJEVofwh28EwzgeNj7bSafn8V1mMlGuWXL3YiY5obBwogkizBJSkbHLB Nf7PQdEiVgFYQBSt2zkbe+0/BrXE2Xq1KrW83OiaVsKxEb+U3RUCc9JVDM5NVQxhULT1 5PYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=1SaB44s5s44iYu4tnf4euOtgADI11yA/LHrk4tXk1Q4=; b=mTSYZcOQQpikeEV/7G3ZRYzZqhCWPqns7yYsHMx/HFas2NyFkTC5epan5UoknSCdPN 1H17tHUtGJ7PuoLUPqNrHCEsQnwgJq8YYAWYVSloHOvtDcMf/iaHqhsmvoFClQSEhoxR z9z8q2Bj0N1XoEiIKBNdC8SlLbJ9+ppXCfjvc7S5Ycfd/ByV9Sr/Lg6s4P+BrQ0OEgsp LQtyNprsVgVD5qSwSMJDlHxxPZFD0/xLOY+vP4sYlg3MdE74um1IF657ZY0wt4rW8hy8 yhllFQeoOwBLe91yZ754yW8grR/8DG/YVL79mh5AiNi5IX0c3jPJWJSgsMlMjnlKHfXW htqA== X-Gm-Message-State: AD7BkJInpmx9Gm5hop/2LXvtH3R+5l7oUr6Z26TJL+zULv2W8cKm30jVswSJuY/PKf4jdB5PAohgsJbA+7f74A== MIME-Version: 1.0 X-Received: by 10.194.90.137 with SMTP id bw9mr11122329wjb.120.1456691057455; Sun, 28 Feb 2016 12:24:17 -0800 (PST) In-Reply-To: <56D2B0B4.4090100@xs4all.nl> References: <201602260114 DOT u1Q1EFRk019336 AT envy DOT delorie DOT com> <201602262010 DOT u1QKA2Hf024379 AT envy DOT delorie DOT com> <201602272322 DOT u1RNMjrQ001204 AT envy DOT delorie DOT com> <56D2B0B4 DOT 4090100 AT xs4all DOT nl> Date: Sun, 28 Feb 2016 11:24:17 -0900 Message-ID: Subject: Re: [geda-user] Re: re-instituting GetXY() From: "Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" To: geda-user AT delorie DOT com Content-Type: text/plain; charset=UTF-8 Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Sat, Feb 27, 2016 at 11:32 PM, Bert Timmerman (bert DOT timmerman AT xs4all DOT nl) [via geda-user AT delorie DOT com] wrote: > Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com] wrote: >> >> On Sat, Feb 27, 2016 at 2:22 PM, DJ Delorie wrote: >> >>> >>> >>>> >>>> Seems to work. So I guess doing things this way the&x and&y args aren't >>>> >>>> used for anything, and the rest of the actions in the sequence know to >>>> get >>>> the coordinates from a global somewhere? >>>> >>> >>> Yup. >>> >>> >>>> >>>> It looks like there are only a handful of actions that set >>>> need_coord_msg >>>> non-NULL. Is there any reason to have both mechanisms? I haven't run >>>> into >>>> anything that seems to need multiple clicks. >>>> >>> >>> Sometimes an action itself needs a point, and provides a reason. It >>> would fail without one, so it says so. >>> >>> Sometimes you mix many actions together, some of which need points, >>> but the reason for the *mix* differs, so you can change the message >>> the user sees. For example, the list of actions that converts a >>> selection to an element needs a point for the element's mark, but none >>> of the individual actions involved know that (IIRC the cut() needs a >>> point, but it doesn't know it's being used to convert an element). >>> >>> In these cases, GetXY() lets you "document" a set of actions in a way >>> that's meaningful to the user. >>> >> >> Ok thanks. At first glance it's highly surprising that GetXY() ends up >> needing >> to declare itself as an action that doesn't require a point, and I suppose >> that's why it's got it's present "". GetXY() effectively acts only on >> behalf >> of other actions. If there's any small renaming or refactor that might >> make >> all this clearer it might be worth it. I don't know what it would be >> though >> so unless you have ideas I'll just comment it in GetXY() and make this >> change. >> >> Britton >> > > Hi, > > These may help: > > http://git.geda-project.org/pcb/commit/?h=home/bert/doxygen&id=8c138288c086870eea9368d119590d68f82a849f > > and > > http://git.geda-project.org/pcb/commit/?h=home/bert/doxygen&id=81d21282cb24d32f376791a3f1e79d86a5c70b1e Nice. I think we're about to change it so it doesn't work exactly that way anymore, so the explanatory tips for the menu items/hotkeys that use GetXY() can work. If you can go ahead and merge these to master I'll update them as appropriate. Britton