X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com Date: Thu, 29 Apr 2021 14:51:49 +0200 (CEST) From: Roland Lutz To: "Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" Subject: Re: [geda-user] xspice integration In-Reply-To: <9d55627f-942e-f4f5-aeea-c4754381e72e@epilitimus.com> Message-ID: References: <9fe0dd9a-cbb8-a51f-f63d-36cd6d3a31c7 AT epilitimus DOT com> <4775a561-41ad-5368-271a-998ded5bfbc6 AT epilitimus DOT com> <07d13043-cd66-88f1-4b6c-172345c864e1 AT epilitimus DOT com> <1425fd69-5796-6cde-198b-8218f71e187d AT epilitimus DOT com> <9d55627f-942e-f4f5-aeea-c4754381e72e AT epilitimus DOT com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk Hi Glenn, On Wed, 28 Apr 2021, Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com] wrote: > 1. Do you have any objections to the symbol hierarchy being more than > one level deep. Specifically there are both control (e.g. > xspice_processor-1.sym) and functional (e.g. xspice_adb-1.sym) xspice > specific devices. My preference is to put them in a directory structure > like: > symbols/xspice/control > symbols/xspice/functional I agree. In order for this to work, you'll probably have to replace "component-library" with "component-library-search" in geda-clib.scm. > 2. There are multiple groups of symbols, Some are xspice specific (e.g. > xspice_dab-1.sym), others are not (e.g. nfet-1.sym [geda currently > doesn't provide a jfet symbol so I drew one]). Do you prefer all the > symbols placed as one commit, one group per commit, one symbol per > commit? Keeping in mind different symbols go to different directories. I don't see a point in splitting xspice-specific symbols into multiple commits. However, for symbols which are not specific to xspice, care must be taken to conform to the conventions of the default library (which may conflict with xspice). I'd rather not open the issue of changing the default library right now, but if you must, please group each logical change as one commit and provide a rationale why this change is necessary. Roland