X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-CMAE-Analysis: v=2.4 cv=d+MwdTvE c=1 sm=1 tr=0 ts=6085fc4a
 a=+cj0cO56Fp8x7EdhTra87A==:117 a=7Ft3ieKuKidl7b7zkEK/bw==:17
 a=9+rZDBEiDlHhcck0kWbJtElFXBc=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19
 a=IkcTkHD0fZMA:10 a=3YhXtTcJ-WEA:10 a=7cjxAn2HFlctzDZ9dp0A:9 a=QEXdDO2ut3YA:10
X-SECURESERVER-ACCT: glimrick AT epilitimus DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=epilitimus.com; s=default; h=Content-Transfer-Encoding:Content-Type:
	In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:
	Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
	Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:
	List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
	bh=ug4X5BdRMt7+BNlRi41sHQB17fyYKKTvtBndf67wsO8=; b=bmgDyohiSXWqThZFYGzIx/auJR
	QXhVM2HYtObjW0eFIk5AJhr0/eHpFHqPR8bDc5F9oHXDotfugUJp5aFFeV60wT/qYcuzsipIrHAGt
	+f36NhoArNoIlpK3qUEkt7rUAPxNQx2QKH0zBLvBlQwmav82BnEYpnm02UNsRmVx00bYYH3oIm1zz
	AFjVeFIoivCY8oKK/eakSrA3Id288FKMw9f64Jiq+8gd+IRJYyD+H6gP2J0OPbqe5AuoigBVd4d2Q
	LGkAd60bv+UpPGphYd0iwiihFUnjpybxEOj0uyOiur7FS5Qp+ZvCeBKQxMkFxDQ+7GthXLZ5eQJK6
	T7Ncv0wg==;
Subject: Re: [geda-user] xspice integration
To: geda-user AT delorie DOT com
References: <b609b43e-9209-3809-ef0e-d3b1e4b11c3c AT epilitimus DOT com>
 <alpine DOT DEB DOT 2 DOT 21 DOT 2104142041100 DOT 7753 AT nimbus>
 <9fe0dd9a-cbb8-a51f-f63d-36cd6d3a31c7 AT epilitimus DOT com>
 <alpine DOT DEB DOT 2 DOT 21 DOT 2104172241210 DOT 6430 AT nimbus>
 <alpine DOT DEB DOT 2 DOT 21 DOT 2104231908590 DOT 5702 AT nimbus>
 <4775a561-41ad-5368-271a-998ded5bfbc6 AT epilitimus DOT com>
 <alpine DOT DEB DOT 2 DOT 21 DOT 2104232352150 DOT 14831 AT nimbus>
 <e2ab51e4-29df-35e0-e16b-4f48dcbc81c8 AT epilitimus DOT com>
 <alpine DOT DEB DOT 2 DOT 21 DOT 2104241511400 DOT 1853 AT nimbus>
 <07d13043-cd66-88f1-4b6c-172345c864e1 AT epilitimus DOT com>
 <alpine DOT DEB DOT 2 DOT 21 DOT 2104252228270 DOT 2187 AT nimbus>
From: "Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Message-ID: <1425fd69-5796-6cde-198b-8218f71e187d@epilitimus.com>
Date: Sun, 25 Apr 2021 15:33:21 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Firefox/60.0 SeaMonkey/2.53.3
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.2104252228270.2187@nimbus>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - a2plcpnl0121.prod.iad2.secureserver.net
X-AntiAbuse: Original Domain - delorie.com
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - epilitimus.com
X-Get-Message-Sender-Via: a2plcpnl0121.prod.iad2.secureserver.net: authenticated_id: glimrick AT epilitimus DOT com
X-Authenticated-Sender: a2plcpnl0121.prod.iad2.secureserver.net: glimrick AT epilitimus DOT com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-CMAE-Envelope: MS4xfIomYtNML4gHlKzIsZXPnWI4zNDDnRq6dIJ8/A1az/I9au7SEaavu9oEPFPQMyRVpyHfwXbq5VgNGusMrl2sWgRG4AFB1fCO+M2MntP3v1jFPIzNCOqq
 kBm2XjdhjeUOC/17TSvMFoGldVVQ+jqvTR6eltifzRTV5b13oCa1AVxKQHRHXexAXHPooBH5GXm9gbEYgeHToB/lffrse3fwmXnyvxDx8w4k2uNg0mzVsLv7
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Roland Lutz wrote:
>
> Huh.  So what I was looking at doesn't really have much in common with
> your latest version...
Yes and no. It does in as much as the base algorithm remained the same.
It doesn't to the extent that there were lots of changes to make things
work the way I wanted them to.
>
> While I'm quite in favor of adding the xspice backend to gEDA/gaf and
> willing to provide the necessary infrastructure from the gnetlist side
> of things, the problem with this backend (as well as your SAB branch)
> is that it's not a series of targeted patches but basically a bunch of
> code that isn't integrated with gEDA/gaf at all.
re: xspice What you are looking at has yet to be integrated into the
geda/gaf tree so no it isn't integrated. The whole point here was to
find out from you where/how you wanted it integrated so that when you
actually started to review it there wasn't a bunch of "this should
really go over there" type of issues. I was actually trying to save you
effort by getting guidance, rather than just sticking stuff into the
tree where I liked it. It really wasn't my intent that you start
reviewing the code until I had integrated it into geda, though your
points below will affect how I structure that.

>
> To help me explain what I mean, have a look at your patch for the gaf
> export "--layout" option (commit 61fd41ea):
>
> <snip>
> If you think gaf should be using constants here instead of plain
> integers (which I agree with), please change that in a separate
> commit.  Since this is a bugfix that is supposed to go into the stable
> branch, the commit changing the "0" to a "1" should go first (I
> already did that, see commit 2077aa58), and the one replacing the
> integers with equivalent constants should go second.  This way, I can
> apply the bugfix to "stable" and both commits to "master".
>
Noted
> librarys = [] #libraries to be included (yes I know it isn't spelled
> right)
>
> I'm completely at a loss here.  If you realized that you spelled it
> wrong, why didn't you fix it?  If there is a reason not to fix it (as
> in, it's spelled that way in the standard), why didn't you document
> that so the next person to touch the code doesn't "fix" it as the
> first thing they do?
>
It was the result of conflicting names, which may or may not still be an
issue, that is something I would look at during cleanup. Again my intent
was to do cleanup/formatting as I was putting stuff into the geda tree.
By the time you actually focused on the code itself these sorts of
issues would be gone. You just got ahead of me.
> Keep in mind that I, too, am puting a lot of hours of good working
> time into this.  The number of round-trips we'll manage before one of
> us has to go off to solve other problems is limited; you won't want to
> waste these on formatting issues.
Let's go back to the question I was asking in the original email I sent
about integrating this into geda/gaf. Given all the moving parts where
would you like things placed/arranged in a general way? Then I can go
off and do that and you can forget about it for a while. I will then put
up a set of patches (keeping all of the above in mind) for the geda tree
which you can then review. The xspice repo was only provided so you had
a chance to look at what was to be added in case you weren't clear on
what something was.

re: SAB I am willing to put together a different set of patches which
will address the above points. Honestly I am not trying to make things
more difficult for you, but both of these projects do add significant
chunks of code to the geda/gaf tree.
>   gEDA/gaf is under the GPL, version 2 or later.  Some files (mostly
> the wiki) are under the GFDL.
GPL is fine with me for the files I am offering.

Glenn