X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YFbzSEQMoefRXR7tR56lQeFBM0tWCyh4Gu/AjqqKy+E=; b=i2k8QiUGrexoCcpkh+pmluzmYpJvSyim2SFGxgmg6XJ5N6AwwQsRsO3MYHLpHlximj WIuon0PjSGZuc+/D6aCOjNM8HPF+hdE/3vu6Es3s3fV4ZkN++zx0IxXHR7EyYKxALP8T gNPPlAHSr1Be3Lt358d3qt8bJUAps8016wrzwvCDTxwRDppDlR5hY65ivUxtxlZmPEme ui1nHdShCf4iwULiUxMzjiGgB4Mhacxs63UFcujERvBo8Asr3jGO/Mwv8M2DGHoiZVua dmkWH3ZViLUulTxBtGZecoeY8YOnt5n2vZ1Zv12x4a3J9JABy5cCl+aLXD2T4l6p2cKO pjdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=YFbzSEQMoefRXR7tR56lQeFBM0tWCyh4Gu/AjqqKy+E=; b=E95cI5KgTSoLdnfpBrEorgbat0yCMI87f1gZnqv85hLOSXVpsT6jFPyPWDatbqwdLX mErvwgYjDP063HIt/l43PtCquualcdNKJXphQDgMrWtj1mzmrlFRXh1OPpswSagE1hXv qGXUUUjVuWOfZVL55OaUwh0P+UkIis911u0PdDg0lQ98B2iUUAGzGlLjUrPsWP4IHcjF 6H1nMNtARTum7A7+KKdaP8B/nY0YI9zwJ6Z/ZBiGMgwrsgBE8M0OzxNEFo7sShtXOClv QzZFnVx0mH0i4a+IUFIauu5LpG0FR2S0y49a4GhMB9/S3RCFs12znMLS1oZ+qsIgwjHY k6/g== X-Gm-Message-State: APjAAAV8yOoBvdCT32/Mx6pjmaj6d9s3o34Va8qJ7nDoTYTia+7IpWL4 QKPgktjut55VDsuPhvZ9L+/OZtxr X-Google-Smtp-Source: APXvYqzYeOlGWBWeMnnURZRGXfXyq3+uHotsSKSUX9CVeVwF9rxqVmHhpvFwXmo6uMwJrbgfeknz+Q== X-Received: by 2002:a2e:87c8:: with SMTP id v8mr8721538ljj.24.1569753197851; Sun, 29 Sep 2019 03:33:17 -0700 (PDT) Date: Sun, 29 Sep 2019 13:33:16 +0300 From: "Vladimir Zhbanov (vzhbanov AT gmail DOT com) [via geda-user AT delorie DOT com]" To: geda-user AT delorie DOT com Subject: Re: [geda-user] Lepton Config Patch Message-ID: <20190929103315.GB2033@newvzh.lokolhoz> Mail-Followup-To: geda-user AT delorie DOT com References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Note-from-DJ: This may be spam Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk Hi Thomas, On Fri, Sep 27, 2019 at 05:03:51PM -0700, Thomas D. Dean (tomdean AT wavecable DOT com) [via geda-user AT delorie DOT com] wrote: > I have a patch to check for proper -dev package when building lepton-geda. > > > diff -c m4/geda-guile.m4.orig m4/geda-guile.m4 > > *** m4/geda-guile.m4.orig Thu Sep 26 10:23:51 2019 > --- m4/geda-guile.m4 Thu Sep 26 10:22:38 2019 > *************** > *** 34,50 **** > GUILE_MIN_MINOR=`echo ${GUILE_MIN_VER} | sed -e 's;[[^\.]]*\.;;' -e > 's;\..*;;g'` > GUILE_MIN_TEENY=`echo ${GUILE_MIN_VER} | sed -e 's;.*\.;;'` > > - _found_pkg_config_guile=yes > PKG_CHECK_MODULES(GUILE, [guile-2.2 >= $GUILE_MIN_VER], > ! [GUILE_PKG_NAME=guile-2.2], > [_found_pkg_config_guile=no]) > > if test "${_found_pkg_config_guile}" = "no" ; then > PKG_CHECK_MODULES(GUILE, [guile-2.0 >= $GUILE_MIN_VER], > [_found_pkg_config_guile=yes > GUILE_PKG_NAME=guile-2.0], > [_found_pkg_config_guile=no]) > - fi > > if test "${_found_pkg_config_guile}" = "no" ; then > AC_MSG_ERROR([you need at least version ${GUILE_MIN_VER} of guile]) > fi > --- 34,68 ---- > GUILE_MIN_MINOR=`echo ${GUILE_MIN_VER} | sed -e 's;[[^\.]]*\.;;' -e > 's;\..*;;g'` > GUILE_MIN_TEENY=`echo ${GUILE_MIN_VER} | sed -e 's;.*\.;;'` > > PKG_CHECK_MODULES(GUILE, [guile-2.2 >= $GUILE_MIN_VER], > ! [_found_pkg_config_guile=yes > ! GUILE_PKG_NAME=guile-2.2], > ! [_found_pkg_config_guile=no]) > > + # if found guile-2.2, check for guile-2.2-dev > + if test "${_found_pkg_config_guile}" = "yes" ; then > + PKG_CHECK_MODULES(GUILE, [guile-2.2-dev >= $GUILE_MIN_VER], > + [_found_pkg_config_guile_dev=yes > + GUILE_PKG_DEV_NAME=guile-2.2-dev], > + [_found_pkg_config_guile=no]) > + fi > + > + ## if did not find guile-2.2, check for guile-2.0 and its dev > if test "${_found_pkg_config_guile}" = "no" ; then > PKG_CHECK_MODULES(GUILE, [guile-2.0 >= $GUILE_MIN_VER], > [_found_pkg_config_guile=yes > GUILE_PKG_NAME=guile-2.0], > [_found_pkg_config_guile=no]) > > + # if found guile-2.0, check for guile-2.0-dev > + if test "${_found_pkg_config_guile}" = "yes" ; then > + PKG_CHECK_MODULES(GUILE, [guile-2.0-dev >= $GUILE_MIN_VER], > + [_found_pkg_config_guile_dev=yes > + GUILE_PKG_DEV_NAME=guile-2.0-dev], > + [_found_pkg_config_guile=no]) > + fi > + fi > + > if test "${_found_pkg_config_guile}" = "no" ; then > AC_MSG_ERROR([you need at least version ${GUILE_MIN_VER} of guile]) > fi First, thank you very much for your work! However, and I am sorry if I understand this correctly :-(, your patch is not portable. It is Debian-specific, that is, it will work on Debian, Ubuntu, and other Debian derivatives, though it won't work on other systems, whose packages have other names. Say, AFAIR, redhat derivatives have '-devel' suffix for development packages. It would be more convenient, if you create an issue on github about it. Lepton package maintainers for non-Debian/non-Linux lepton distributions (Dominique, dmn, ...), please let us know your opinions on this. TIA -- Vladimir (λ)επτόν EDA — https://github.com/lepton-eda