X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=c0RbHUaFdu3w3gAwNrixdHySqrOrAJ8I4VkNgpfDPDs=; b=Zr6wtx8EdV8dqnhx3y4YYYyRgRHjtIC2BGdiFJMEdBgOLSQmM79s1gzn/gFTPaLnpz qSw+AkzdkkBkR9ILJQBujYNQcHW4me4pc1zvxvimLc4IBbHnvWeAdiUntzgeR2drzWCy AZyMAZfuyYjIaxRghRIs4otM4hYIa6OsyAUV5n2C2x9uwtxHzXCa78stTawdiNBkDwUt 8+D0flMEHd2cEroT18PzAYficInBlLWmi9yb///lP1Y+kXP1Hmf1vJr1rqfs8JbSjw1g Q3UOoFLZtw++h+UinrUA3tEi2Am6V+Um4DZ75di6DPubUJaQkcjHKuaWE5FF/7HoTPLl Pw+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=c0RbHUaFdu3w3gAwNrixdHySqrOrAJ8I4VkNgpfDPDs=; b=pE6RT90cbdFTykTb2c6TEO09zh5vQij1Nu5STUOC4qlqGNyXCgwazc4rGI4KZPgGZ8 5pYnAarTjJ8PutBOj9GJNs6w42z1cbWLOVt3CJFCUwwvw6MedUpniFBDfYMN4RO61Jab +e63YMGzwzo7vP+TWXTEt0E5egJodxIXwkyRxiYuI8A0xfWcG1j3ytcNLrLvz+jBL4bx NvgaEkFSUILxLLfyL1cypVlCjl2XSD0jKoekob5VhSoJmVdQKJVQiwxVvI9yhSdOb4xM J5qRfqLFyTNjTe6WGBs/l/yhdGcu6N03+wPmNrtROBlojy53QFMq+LUTKtrfjIKkmMQ8 30yQ== X-Gm-Message-State: AIkVDXLTIPW1LnhhLUGu5dz3+4M68LZBGyYjnm/Wj54i8eQbDW9d+Emi2XorNbdPIijJ7i2FZlYr9jpRZL8e+w== X-Received: by 10.194.117.134 with SMTP id ke6mr56192074wjb.123.1483527115913; Wed, 04 Jan 2017 02:51:55 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <88b3e5e4-c237-108c-43b1-deb75a2e324a@mcmahill.net> References: <88b3e5e4-c237-108c-43b1-deb75a2e324a AT mcmahill DOT net> From: "Sergey Alyoshin (alyoshin DOT s AT gmail DOT com) [via geda-user AT delorie DOT com]" Date: Wed, 4 Jan 2017 13:51:55 +0300 Message-ID: Subject: Re: [geda-user] pcb distcheck target fails from pcb-menu.res.h To: geda-user AT delorie DOT com Content-Type: text/plain; charset=UTF-8 Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Wed, Jan 4, 2017 at 2:23 AM, Dan McMahill (dan AT mcmahill DOT net) [via geda-user AT delorie DOT com] wrote: > On 1/3/2017 2:43 PM, Sergey Alyoshin (alyoshin DOT s AT gmail DOT com) [via > geda-user AT delorie DOT com] wrote: >> >> On Tue, Jan 3, 2017 at 7:20 AM, Dan McMahill (dan AT mcmahill DOT net) [via >> geda-user AT delorie DOT com] wrote: >>> >>> I tried to run 'make distcheck' on pcb master today and found that there >>> seems to be some broken stuff in src/Makefile.am related to menu resource >>> file translations. >>> >>> One of the things 'make distcheck' does is to verify that you can build >>> from >>> outside the source tree with a read only source tree. pcb-menu.res.h gets >>> generated and then we try to copy to $srcdir (this seems broken, we >>> should >>> not be writing back to $srcdir). That of course fails but there is a >>> hack >>> in Makefile.am to get past that. But the later on there are complaints >>> that >>> sub/src/pcb-menu.res.h and sub/src/gpcb-menu.res.h contain translations >>> but >>> weren't listed in POTFILES.in. This is because what is listed in >>> POTFILES.in is the *source* version, not the version which was generated >>> in >>> the build tree. Are these .res.h files actually used? It has been a few >>> years since I last dug into the menu code. >> >> >> Yes messages from *-menu.res.h are necessary and resulted in po/*.po >> >>> Does anyone know if the menu translation stuff actually works? Was the >>> goal >>> to have translations for the default menus? >> >> >> Menu is translated in commit 0a2a7efffbc3664ba14e75b479d9199ea2528a0 >> from origin/home/cparker/4.0.0 >> >> src/*-menu.res.h after commit 91a528eff37a76518dec5d15cd03df8c7ee0969b >> now listed both in po/POTFILES.in and in po/POTFILES.skip >> >> If src/*-menu.res.h are removed from po/POTFILES.in then all menu >> strings is not translated. >> > > oh, I see. Those *-menu.res.h files are generated to the i18n tools can > extract strings to go in the po files. Then when the actual menus are > parsed at run time, either from a file or compiled in defaults, they are > translated. That is why these files do not show up anywhere else. Is this > correct? Yes, exactly. > I think the handling of those files but the build system isn't quite right > but that I can probably fix without breaking stuff.