X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Subject: Re: [geda-user] pcb distcheck target fails from pcb-menu.res.h
To: geda-user AT delorie DOT com
References: <f1226321-a1f7-f46a-63c8-867024b13f87 AT mcmahill DOT net>
 <CAOxVtSScXqz0QMez+=DfNYA3pACD=QQgiT2uGJGcRCSFif4W9w AT mail DOT gmail DOT com>
From: "Dan McMahill (dan AT mcmahill DOT net) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Message-ID: <88b3e5e4-c237-108c-43b1-deb75a2e324a@mcmahill.net>
Date: Tue, 3 Jan 2017 18:23:58 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <CAOxVtSScXqz0QMez+=DfNYA3pACD=QQgiT2uGJGcRCSFif4W9w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfNS/eBmC+poB+U65IetHPXhtFQPDBKDwXISEsVGvxdzQitNmK+m9eNoJqkH4g/ZXdvG4xrQaGR3dlCKvIZDwgxR/1b3yN87NlLXhkwf59NnspO4ZSijW
 8r8cckUdQUWoBCBVsTsSvjq0XpiH2TFHIwZQ68r6zwoO3eYWNnYSNO3p
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On 1/3/2017 2:43 PM, Sergey Alyoshin (alyoshin DOT s AT gmail DOT com) [via 
geda-user AT delorie DOT com] wrote:
> On Tue, Jan 3, 2017 at 7:20 AM, Dan McMahill (dan AT mcmahill DOT net) [via
> geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote:
>> I tried to run 'make distcheck' on pcb master today and found that there
>> seems to be some broken stuff in src/Makefile.am related to menu resource
>> file translations.
>>
>> One of the things 'make distcheck' does is to verify that you can build from
>> outside the source tree with a read only source tree. pcb-menu.res.h gets
>> generated and then we try to copy to $srcdir (this seems broken, we should
>> not be writing back to $srcdir).  That of course fails but there is a hack
>> in Makefile.am to get past that.  But the later on there are complaints that
>> sub/src/pcb-menu.res.h and sub/src/gpcb-menu.res.h contain translations but
>> weren't listed in POTFILES.in.  This is because what is listed in
>> POTFILES.in is the *source* version, not the version which was generated in
>> the build tree.  Are these .res.h files actually used?  It has been a few
>> years since I last dug into the menu code.
>
> Yes messages from *-menu.res.h are necessary and resulted in po/*.po
>
>> Does anyone know if the menu translation stuff actually works?  Was the goal
>> to have translations for the default menus?
>
> Menu is translated in commit 0a2a7efffbc3664ba14e75b479d9199ea2528a0
> from origin/home/cparker/4.0.0
>
> src/*-menu.res.h after commit 91a528eff37a76518dec5d15cd03df8c7ee0969b
> now listed both in po/POTFILES.in and in po/POTFILES.skip
>
> If src/*-menu.res.h are removed from po/POTFILES.in then all menu
> strings is not translated.
>

oh, I see.  Those *-menu.res.h files are generated to the i18n tools can 
extract strings to go in the po files.  Then when the actual menus are 
parsed at run time, either from a file or compiled in defaults, they are 
translated.  That is why these files do not show up anywhere else.  Is 
this correct?

I think the handling of those files but the build system isn't quite 
right but that I can probably fix without breaking stuff.

-Dan