X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:subject:message-id:in-reply-to:references:mime-version
         :content-type:content-transfer-encoding;
        bh=5f6uxXyyeHqvT9cRN/hYV/75JC0v2QuM4/usMcHaiaQ=;
        b=NsvcbNZpN0K8hN9GXJB/KTmJCWhSjOus1uanI6zGcyE0MtZRuoHAPs1sp8Web1ndx0
         9LY1iaN3dfKNfa6JAiGbOPElU9YWmrIqFPbkDWjOPHBTadeOusB6vAkPTZNqJulnzFrZ
         YkkJixebqgXbDemQ0L2jjBHYZE+2FPy3H1y95CKUwMMeE//ZB/tuIYwj8XtDjTvrN8N1
         nf2zxT5bKevidXqPeFuxiE5AcUnIZ0x0a5C6BMYNOr1l2F1eom0ymx2lYzvEb/g6UlMA
         Ae1vmVKX7x8YUybeqFzj9MumTimqATotMdapdKusfSAHoBEXI10PBacMvWNL90sA7oF+
         XHrA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to
         :references:mime-version:content-type:content-transfer-encoding;
        bh=5f6uxXyyeHqvT9cRN/hYV/75JC0v2QuM4/usMcHaiaQ=;
        b=IqIeZ7iwrfr4G+xQK/ETjUxao6IhwntyM4dVbjwxtNt9QsCtQKVcItxUt7hAn/05KN
         pYWv/pJX1K9PNcjS76sNfOrLLcXmo9R1cF6P3rRZ6KPH/10771Ql2VJuRvtkGDl6jamu
         VqYkkWG4BnJxjDueuptXDXhsM9dYP/qYnVvcnBkQGqb0hyIZng18ZBzrIzg/bqypv6SG
         +/hGFDfbej/HQFOvpm1Q1f4Bc34mai0GSJMBRsFqUpQWihF90hGtPAetOp/1aPVUXcvT
         o3B3iCc2drWZMEzRmQ7Hv3OiXSnuT8JLiKfXSsBiL47t1MiLVVn1a54q522Lg0axkv65
         iMlA==
X-Gm-Message-State: AG10YOSf1kvchfM5kUIry4CdXs8vMVjalE5RyQ8zP3UtgpQmC92+QrMPEz4Pxw0Z6SZ+0g==
X-Received: by 10.28.45.71 with SMTP id t68mr18318515wmt.46.1455605688943;
        Mon, 15 Feb 2016 22:54:48 -0800 (PST)
Date: Tue, 16 Feb 2016 07:54:47 +0100
From: "Nicklas Karlsson (nicklas DOT karlsson17 AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [pcb-rnd] dmalloc (clean up)
Message-Id: <20160216075447.cce1754775bd6dd35322c6d9@gmail.com>
In-Reply-To: <alpine.DEB.2.00.1602160645540.7885@igor2priv>
References: <alpine DOT DEB DOT 2 DOT 00 DOT 1602160645540 DOT 7885 AT igor2priv>
X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Code clean up is always nice.

Regards Nicklas Karlsson


On Tue, 16 Feb 2016 06:55:29 +0100 (CET)
gedau AT igor2 DOT repo DOT hu wrote:

> Hi all,
> 
> I figured how to keep dmalloc support in pcb-rnd without having to have it 
> included in all .c files. The reason I wanted to do this is this: 
> if one adds a new file and forgets to add the 3 line boiler plate code, it 
> probably goes unnoticed while it may make a subtle difference in the 
> output.
> 
> Since all source files generally need to include config.h, and 
> HAVE_LIBDMALLOC is defined there anyway, I decided to move the #include 
> there too. This means if a source file did work with dmalloc before the 
> modification, it surely will work after the modification since it had to 
> include config.h already for the feature macro.
> 
> I've written an awk fewliner that edited out the
> 
> #ifdef HAVE_LIBDMALLOC
> #include <dmalloc.h>
> #endif
> 
> lines from all source files.
> 
> Just sharing this because I believe mainline pcb could benefit from a 
> similar change.
> 
> Regards,
> 
> Igor2