X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=Eqb7KmQkeG6t1AhX6T157dcfoWJKV5UzeWR/ivbHoTw=;
        b=F08SF9SQ/8b/QGrGhv84UqFQ0ftst2CEUxImx6ybC0frRIkNxL9JXrjCPSIrCNBwsk
         vOzueveIFnXaCuakd+qMIPNMD8Wmiq70/5Uc6tUNBAJxNHIZmOJIJOEoyWwWQBdvdMtg
         b+favx5XLXgbiIMrwSoWUDOoHQa0XuQY0e6yrJN1gikPffd6WL9wuMHNp7C4O8t7Eq72
         BBhUm07F6Y4h8jAc+bkIqtY5gE8qOTbdEe3aI3c+Y/DHEGwXtmLGuUpQgr1VVdp2yl4I
         oaVp9XOfrm9fjM2cGXwRs5GVwDhUu9yvkYCRRV89ae2L7Ik/SqL4sitelwjKdEZ7HjWL
         rUug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:content-type;
        bh=Eqb7KmQkeG6t1AhX6T157dcfoWJKV5UzeWR/ivbHoTw=;
        b=dUqQ05qJucDe2dMBrfUT9bILu5SXXb/TI4Ft8ZzSbt9tzzE02r/CBGEaQU3O18qDWK
         k7DtezOiYN2IKf5m5oOYZ4I6OMJ+v3REpd/6ENlC+RUCBrkr0z+k2Ij7La+m0KvT7vuy
         NjI/6Qsw3Omzxu5rWwxLgaQD27y46beHFDp/EGWADfGY3pd6nbQQN9FCmVCMY930+FAy
         CX2YX9e+iIquG+4ZY5hoWKok5w6IMACEx//6VqJ8j+3o/WdVwzvWEf+wqrEoZhnerMuA
         Oj83pO1JWQzCV+OzlC+nC9GrxAPi2c9cNXh3icBjdkTsN/BpMn5qzhuf4qv0xzT+OG1X
         QhXA==
X-Gm-Message-State: AG10YOQ5cBz4NgRax7HCsuW9jTUq2TcuWvC9Kfh8q9qBpOpIOFlUqj/8QpPxRMFWd1e/J5cQ0eWnE7exL3a2dg==
MIME-Version: 1.0
X-Received: by 10.28.125.147 with SMTP id y141mr19790755wmc.18.1453232098372;
 Tue, 19 Jan 2016 11:34:58 -0800 (PST)
In-Reply-To: <201601172146.u0HLkPnT008691@envy.delorie.com>
References: <CAC4O8c88EnAJ1H4YL4rj2O10ihZAz_NYDMSBAWEmdknMNu2b4A AT mail DOT gmail DOT com>
	<CAJXU7q8AtP=UOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gmail DOT com>
	<569BCA7F DOT 70903 AT prochac DOT sk>
	<569BCC77 DOT 60700 AT iee DOT org>
	<CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw AT mail DOT gmail DOT com>
	<201601172146 DOT u0HLkPnT008691 AT envy DOT delorie DOT com>
Date: Tue, 19 Jan 2016 10:34:58 -0900
Message-ID: <CAC4O8c8u_X54Ro2idbfBf8WToHg0tt2=BJ_irEHcZ7BVH6-_BQ@mail.gmail.com>
Subject: Re: [geda-user] cleaner version of fixes to file format plugin
From: "Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Content-Type: multipart/alternative; boundary=001a11419974fffd490529b4f6cf
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

--001a11419974fffd490529b4f6cf
Content-Type: text/plain; charset=UTF-8

On Sun, Jan 17, 2016 at 12:46 PM, DJ Delorie <dj AT delorie DOT com> wrote:

>
> > A number of devels don't actually like the current preferred style, but
> > want to continue using it perhaps out of respect for the original devels.
> > Who aren't even around any more.
>
> No, the request is that you continue to honor whatever style was there
> before, so that the style remains consistent throughout, which
> increases readability.
>
> Arbitrary changes to style cause diffs to be much bigger than are
> needed to convey the meaning of a change, so you should never
> gratuitously change the style of code in the same patch as anything
> else.  Requests to do nothing other than change the style result in a
> history that hides other changes behind the style change.
>
> So stick with the existing style, and don't change it unless you have
> a REALLY good reason to.
>
> > Indentation matters, local consistency matters, // vs /* and which line
> > braces go on don't.
>
> // vs /* matters if the compiler doesn't support C99 yet.
>
> Granted, most do, but nobody's actually clarified that issue.  Until
> then, and until we officially require a C99 compiler *and test for
> it*, // is still to be avoided.
>

I made branch home/bkerin/require_C99 a while ago and posted about it

Britton

--001a11419974fffd490529b4f6cf
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Sun, Jan 17, 2016 at 12:46 PM, DJ Delorie <span dir=3D"ltr">&lt;<a h=
ref=3D"mailto:dj AT delorie DOT com" target=3D"_blank">dj AT delorie DOT com</a>&gt;</spa=
n> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b=
order-left:1px #ccc solid;padding-left:1ex"><br>
&gt; A number of devels don&#39;t actually like the current preferred style=
, but<br>
&gt; want to continue using it perhaps out of respect for the original deve=
ls.<br>
&gt; Who aren&#39;t even around any more.<br>
<br>
No, the request is that you continue to honor whatever style was there<br>
before, so that the style remains consistent throughout, which<br>
increases readability.<br>
<br>
Arbitrary changes to style cause diffs to be much bigger than are<br>
needed to convey the meaning of a change, so you should never<br>
gratuitously change the style of code in the same patch as anything<br>
else.=C2=A0 Requests to do nothing other than change the style result in a<=
br>
history that hides other changes behind the style change.<br>
<br>
So stick with the existing style, and don&#39;t change it unless you have<b=
r>
a REALLY good reason to.<br>
<br>
&gt; Indentation matters, local consistency matters, // vs /* and which lin=
e<br>
&gt; braces go on don&#39;t.<br>
<br>
// vs /* matters if the compiler doesn&#39;t support C99 yet.<br>
<br>
Granted, most do, but nobody&#39;s actually clarified that issue.=C2=A0 Unt=
il<br>
then, and until we officially require a C99 compiler *and test for<br>
it*, // is still to be avoided.<br>
</blockquote></div><br></div><div class=3D"gmail_extra" style=3D"">I made b=
ranch home/bkerin/require_C99 a while ago and posted about it</div><div cla=
ss=3D"gmail_extra" style=3D""><br></div><div class=3D"gmail_extra" style=3D=
"">Britton</div></div>

--001a11419974fffd490529b4f6cf--