X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Message-ID: <569C0C95.8020100@iee.org>
Date: Sun, 17 Jan 2016 21:50:13 +0000
From: "M. J. Everitt (m DOT j DOT everitt AT iee DOT org) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] cleaner version of fixes to file format plugin
References: <CAC4O8c88EnAJ1H4YL4rj2O10ihZAz_NYDMSBAWEmdknMNu2b4A AT mail DOT gmail DOT com>	<CAJXU7q8AtP=UOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gmail DOT com>	<569BCA7F DOT 70903 AT prochac DOT sk>	<569BCC77 DOT 60700 AT iee DOT org> <CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw AT mail DOT gmail DOT com>
In-Reply-To: <CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------010603070502080006000001"
X-Provags-ID: V03:K0:n+0yC5TplScvjNK1+PHQgTQPuociMC7/kfZ5he+sUCkW2Q2XOwn
 oMv+Blg8AFuVcvIYYQvQO9IzOXNWRWsq3WGoGx3EXWxFnJRnDXXgptas2ZJyS7Wkrq7EK8X
 dka16CHiADxCUIW8kifFW2g+X1YOo8/AfsjXUHIp5erHwjYK1y8yMLcUd2h/MenM2An6Eut
 xF6Isn6bNO/3vLZS2LDPA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:1iyakGwpd18=:1qOR6PKjYcwVMNWCo22k2z
 1vAvR99KGvSVZ93dD30+iK1DkOi+3RU80y35if6RzMyhzAUZi1/nG4sLhdpHBAucOI4qXnhaI
 mjONUR6M3SJ1IuT+q6wF8aNk9PDbzW2zj03AJQDFBlatthC/qPt40qEQJFMkqYqPhp3bYhuXW
 ym34Z02nVvsnigXNrCxCbNC8CJ2vlnib2J4n6z/5zP/wEbxXyUn5Dnt3hoxjU2q/Bl//Grx5K
 ARqRVRSIT2soytnxPbiGQI+MGKkge6bzzJXDqkTo7v6crPe6vqQ+3gyixi0FEtMUhB0R3y7lc
 YY2yNH8mdswzgqi2ZzYxFm3ynctL/y8Jin9KhEU2nLO6lD9YRyYTWHuBr0nOJtWuaH0fLZ14b
 mOY7XFgOrq8yrvyfBTAVeIqZFdSyye0f7qYumE0fIEhVwSlG13/eCtCrkfeocIls4o/rMeRsw
 PT0ropsWln3XYFYjI5o0rl7WWcpU8s2Ugvt7fFDSHtWoVFt7yY0FCKs0tvPC2H0cI+dsG/0n3
 KuqTHjcad95bj3sc8rUq3bcTH3iMlwMTX5gBWGUR1gNRGGN2OXavy5wXnUILlcvrjJwZfF4So
 zfoJ+LiqHlMarL3bNpQpinE8A8zklx7s1scwuj0kI5xRU6L1htl4aFNEMNyZZiT+wMIHgIB4S
 4mojjHUDxLYCrCcp4Eu0qYl0QzMuHhodVOka0/YiR/AVDQoVKUwolXJ1r33ns5xChLPAdh4Pp
 9t1Q1Ybr3/XP2lgZ
Reply-To: geda-user AT delorie DOT com

This is a multi-part message in MIME format.
--------------010603070502080006000001
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 17/01/16 21:34, Britton Kerin (britton DOT kerin AT gmail DOT com) [via
geda-user AT delorie DOT com] wrote:
>
>
> On Sun, Jan 17, 2016 at 8:16 AM, M. J. Everitt (m DOT j DOT everitt AT iee DOT org
> <mailto:m DOT j DOT everitt AT iee DOT org>) [via geda-user AT delorie DOT com
> <mailto:geda-user AT delorie DOT com>] <geda-user AT delorie DOT com
> <mailto:geda-user AT delorie DOT com>> wrote:
>
>
>     On 17/01/16 17:08, Milan Prochac (milan AT prochac DOT sk
>     <mailto:milan AT prochac DOT sk>) [via
>     geda-user AT delorie DOT com <mailto:geda-user AT delorie DOT com>] wrote:
>     > On 17. 1. 2016 13:24, Peter Clifton
>     (petercjclifton AT googlemail DOT com <mailto:petercjclifton AT googlemail DOT com>)
>     > [via geda-user AT delorie DOT com <mailto:geda-user AT delorie DOT com>] wrote:
>     >> No // comments please.
>     >>
>     >
>     > Well, but they seems to be quite common:
>     >
>     > $ git status
>     > # On branch master
>     > nothing to commit, working directory clean
>     > $ grep -R // * | grep // | wc -l
>     > 527
>     >
>     > Milan
>     >
>     Better to have some QA scripts that pick these things out, than use
>     compiler options. Even better still, use commit hooks to run these
>     scripts so that you cannot commit without fixing any issues.
>
>
> Even better would be to ignore them, since they aren't really issues. 
> It's window dressing, you might put it on after everything else is
> perfect, which is not the case here.  Putting it on fixes nothing real.
>
> A number of devels don't actually like the current preferred style,
> but want to continue using it perhaps out of respect for the original
> devels.  Who aren't even around any more.
>
> Indentation matters, local consistency matters, // vs /* and which
> line braces go on don't.
>
> Britton
Totally in agreement .. food for the 'coding standard' debate that's
floating around .. what would people 'prefer' was the 'right' way?!

--------------010603070502080006000001
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <br>
    <div class="moz-cite-prefix">On 17/01/16 21:34, Britton Kerin
      (<a class="moz-txt-link-abbreviated" href="mailto:britton DOT kerin AT gmail DOT com">britton DOT kerin AT gmail DOT com</a>) [via <a class="moz-txt-link-abbreviated" href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>] wrote:<br>
    </div>
    <blockquote
cite="mid:CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw AT mail DOT gmail DOT com"
      type="cite">
      <div dir="ltr"><br>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On Sun, Jan 17, 2016 at 8:16 AM, M.
            J. Everitt (<a moz-do-not-send="true"
              href="mailto:m DOT j DOT everitt AT iee DOT org">m DOT j DOT everitt AT iee DOT org</a>)
            [via <a moz-do-not-send="true"
              href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>]
            <span dir="ltr">&lt;<a moz-do-not-send="true"
                href="mailto:geda-user AT delorie DOT com" target="_blank">geda-user AT delorie DOT com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
              On 17/01/16 17:08, Milan Prochac (<a
                moz-do-not-send="true" href="mailto:milan AT prochac DOT sk">milan AT prochac DOT sk</a>)
              [via<br>
              <div>
                <div class="h5"><a moz-do-not-send="true"
                    href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>]
                  wrote:<br>
                  &gt; On 17. 1. 2016 13:24, Peter Clifton (<a
                    moz-do-not-send="true"
                    href="mailto:petercjclifton AT googlemail DOT com">petercjclifton AT googlemail DOT com</a>)<br>
                  &gt; [via <a moz-do-not-send="true"
                    href="mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>]
                  wrote:<br>
                  &gt;&gt; No // comments please.<br>
                  &gt;&gt;<br>
                  &gt;<br>
                  &gt; Well, but they seems to be quite common:<br>
                  &gt;<br>
                  &gt; $ git status<br>
                  &gt; # On branch master<br>
                  &gt; nothing to commit, working directory clean<br>
                  &gt; $ grep -R // * | grep // | wc -l<br>
                  &gt; 527<br>
                  &gt;<br>
                  &gt; Milan<br>
                  &gt;<br>
                </div>
              </div>
              Better to have some QA scripts that pick these things out,
              than use<br>
              compiler options. Even better still, use commit hooks to
              run these<br>
              scripts so that you cannot commit without fixing any
              issues.<br>
            </blockquote>
            <div><br>
            </div>
            <div style="">Even better would be to ignore them, since
              they aren't really issues.  It's window dressing, you
              might put it on after everything else is perfect, which is
              not the case here.  Putting it on fixes nothing real.</div>
            <div style=""><br>
            </div>
            <div style="">A number of devels don't actually like the
              current preferred style, but want to continue using it
              perhaps out of respect for the original devels.  Who
              aren't even around any more.</div>
            <div style=""><br>
            </div>
            <div style="">Indentation matters, local consistency
              matters, // vs /* and which line braces go on don't.</div>
            <div style=""><br>
            </div>
            <div style="">Britton</div>
          </div>
        </div>
      </div>
    </blockquote>
    Totally in agreement .. food for the 'coding standard' debate that's
    floating around .. what would people 'prefer' was the 'right' way?!<br>
  </body>
</html>

--------------010603070502080006000001--