X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
Date: Sun, 17 Jan 2016 16:46:25 -0500
Message-Id: <201601172146.u0HLkPnT008691@envy.delorie.com>
From: DJ Delorie <dj AT delorie DOT com>
To: geda-user AT delorie DOT com
In-reply-to:
	<CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw AT mail DOT gmail DOT com>
	(geda-user AT delorie DOT com)
Subject: Re: [geda-user] cleaner version of fixes to file format plugin
References: <CAC4O8c88EnAJ1H4YL4rj2O10ihZAz_NYDMSBAWEmdknMNu2b4A AT mail DOT gmail DOT com>
	<CAJXU7q8AtP=UOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gmail DOT com>
	<569BCA7F DOT 70903 AT prochac DOT sk>
	<569BCC77 DOT 60700 AT iee DOT org> <CAC4O8c9_kMdr+3xhe4-CZvUxPGzgqBrLN=Kn+WdGqGVcV1Nbnw AT mail DOT gmail DOT com>
Reply-To: geda-user AT delorie DOT com


> A number of devels don't actually like the current preferred style, but
> want to continue using it perhaps out of respect for the original devels.
> Who aren't even around any more.

No, the request is that you continue to honor whatever style was there
before, so that the style remains consistent throughout, which
increases readability.

Arbitrary changes to style cause diffs to be much bigger than are
needed to convey the meaning of a change, so you should never
gratuitously change the style of code in the same patch as anything
else.  Requests to do nothing other than change the style result in a
history that hides other changes behind the style change.

So stick with the existing style, and don't change it unless you have
a REALLY good reason to.

> Indentation matters, local consistency matters, // vs /* and which line
> braces go on don't.

// vs /* matters if the compiler doesn't support C99 yet.

Granted, most do, but nobody's actually clarified that issue.  Until
then, and until we officially require a C99 compiler *and test for
it*, // is still to be avoided.