X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Ironport-SBRS: None X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2EfBQA5yZtW/52AA4BegzqBP4JkhXK1HoYPAoEZOxEBAQEBAQEBA4EHhDUBAQQ6TwsYCRMSDwVJE4gGAxIFulcNg0cBAQgCASCGVYR/gk+FU4EbBY45iGGNVoFnhESIX4psg3E4LIQsHTSHHwEBAQ X-IronPort-AV: E=Sophos;i="5.22,308,1449561600"; d="scan'208";a="11326491" Date: Sun, 17 Jan 2016 09:04:45 -0800 From: Larry Doolittle To: "Milan Prochac (milan AT prochac DOT sk) [via geda-user AT delorie DOT com]" Subject: Re: [geda-user] cleaner version of fixes to file format plugin Message-ID: <20160117170444.GA10289@recycle.lbl.gov> References: <569BBE0A DOT 3060407 AT prochac DOT sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <569BBE0A.3060407@prochac.sk> User-Agent: Mutt/1.5.21 (2010-09-15) Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Sun, Jan 17, 2016 at 05:15:06PM +0100, Milan Prochac (milan AT prochac DOT sk) [via geda-user AT delorie DOT com] wrote: > On 17. 1. 2016 13:24, Peter Clifton (petercjclifton AT googlemail DOT com) > [via geda-user AT delorie DOT com] wrote: > >No // comments please. > These was just missed durin cleanup, these lines were supposed to be > deleted. it's already cleaned (I use // comments as simplest way to > mark code to be deleted) If (as it sounds) y'all are trying to stay c89 compatible, please try your builds with the gcc (or clang) switch "--std=c89". That will flag // comments for you. Automated checks beat code review any day of the week. This doesn't mean that such a switch needs to be enabled by default for casual users. - Larry