On 15. 1. 2016 2:51, Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com] wrote:

On Thu, Jan 14, 2016 at 2:20 PM, Milan Prochac (milan AT prochac DOT sk) [via geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote:

On 12. 1. 2016 20:23, Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com] wrote:

I'm working on this branch there are some minor issues. I'll push fixes to LP1532611_fixes

Can you share details about the issues? I guess I can identify the culprit and prepare fix faster

Attached is a patch showing roughly what I've found. The fftemplate.c is entirely in this patch but I didn't change anything in it besides including assert.h I think.

The "patch" is not readable/applicable. Can you please provide the copy without color ANSI sequences?

It comes down to a little more honoring of default format (e.g. making sure its in default position in format list in SaveAs, checks that only one defualt format is specified, and stuff to take care of situation where PCB->Filename is known and PCB->Fileformat not. Some or all of that last category of change may be uneeded with the patch you propose for invalid file arguments (which I think is the right fix for that).

I will review my changes and ensure that PCB->Fileformat is valid when PCB->Filename is known. The assignment of filename from commandline was missed, but all other situations should be handled properly.

Please note that patch LP1534373 is for PCB without modular file format. It will require one more line to support modular formats - set the default format along with filename of non-existing board.

I'd like for you to "own" this code for sure as you can almost surely improve it faster and better, but I'd like to start using it as well. If you aren't wanting to use git yet it would be nice to get you synced up with a repository version (one way or another, either you can sync to home/bert/LP1532611 or we could declare the edits in that branch premature and restart it with a new patch from you). You can then send patches to whoever owns the branch so people can track it.

I will post all fixes to the existing LP as additional patches. Once patch is published, I will not modify it or recall it.

I am not very comfortable with the proposed development model (spread patches over various private branches) as I do not see clear way from bug report (with patch added) to its merging to master branch.

Milan