X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prochac.sk;
	s=default; t=1452944740;
	bh=3odhsXatj4s/htaGw0brxVObI3SR8DD/sOTf+5C8dIc=;
	h=Subject:To:References:From:Date:In-Reply-To;
	b=MYd54lfgVNXNGkJfHj1DroQ1sJVggFUNDSog7Yyrwn3ozj26/aPhqjGxgCiWMI6e1
	 ngQ5FhlQwCTjiiZ4SOhOq1HUyOdPWFzHMWFuMi3HkNtGHOs/O1E+OtKD2ehzjrTkga
	 y5YIXqBU6gu0mKIuKw41prxTxIPTHJ+LAVPESt54=
X-Clacks-Overhead: "GNU Terry Pratchett"
Subject: Re: [geda-user] LP1532611 (modular fie formats) fixes
To: geda-user AT delorie DOT com
References: <CAC4O8c8tTutWKvXFA-nfcmUiUGYbOY1_5171Vf3WDk09Tmx3yw AT mail DOT gmail DOT com>
 <56982D5A DOT 1020706 AT prochac DOT sk>
 <CAC4O8c93jC=qRPAHnzBCrVYONGnyvQ55qv5yQ-vor8es-0_meg AT mail DOT gmail DOT com>
From: "Milan Prochac (milan AT prochac DOT sk) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Message-ID: <569A2DAC.9070200@prochac.sk>
Date: Sat, 16 Jan 2016 12:46:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <CAC4O8c93jC=qRPAHnzBCrVYONGnyvQ55qv5yQ-vor8es-0_meg@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------020106010703000308020505"
X-Spam-Status: No, score=-101.0 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,
	USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on angua.bastl.sk
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

This is a multi-part message in MIME format.
--------------020106010703000308020505
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15. 1. 2016 2:51, Britton Kerin (britton DOT kerin AT gmail DOT com) [via 
geda-user AT delorie DOT com] wrote:
>
> On Thu, Jan 14, 2016 at 2:20 PM, Milan Prochac (milan AT prochac DOT sk 
> <mailto:milan AT prochac DOT sk>) [via geda-user AT delorie DOT com 
> <mailto:geda-user AT delorie DOT com>] <geda-user AT delorie DOT com 
> <mailto:geda-user AT delorie DOT com>> wrote:
>
>     On 12. 1. 2016 20:23, Britton Kerin (britton DOT kerin AT gmail DOT com
>     <mailto:britton DOT kerin AT gmail DOT com>) [via geda-user AT delorie DOT com
>     <mailto:geda-user AT delorie DOT com>] wrote:
>
>
>         I'm working on this branch there are some minor issues.  I'll
>         push fixes to LP1532611_fixes
>
>
>     Can you share details about the issues? I guess I can identify the
>     culprit and prepare fix faster
>
>
> Attached is a patch showing roughly what I've found.  The fftemplate.c 
> is entirely in this patch but I didn't change anything in it besides 
> including assert.h I think.
>

The "patch" is not readable/applicable. Can you please provide the copy 
without color ANSI sequences?

> It comes down to a little more honoring of default format (e.g. making 
> sure its in default position in format list in SaveAs, checks that 
> only one defualt format is specified, and stuff to take care of 
> situation where PCB->Filename is known and PCB->Fileformat not.  Some 
> or all of that last category of change may be uneeded with the patch 
> you propose for invalid file arguments (which I think is the right fix 
> for that).

I will review my changes and ensure that PCB->Fileformat is valid when 
PCB->Filename is known. The assignment of filename from commandline was 
missed, but all other situations should be handled properly.

Please note that patch LP1534373 is for PCB without modular file format. 
It will require one more line to support modular formats - set the 
default format along with filename of non-existing board.

> I'd like for you to "own" this code for sure as you can almost surely 
> improve it faster and better, but I'd like to start using it as well.  
> If you aren't wanting to use git yet it would be nice to get you 
> synced up with a repository version (one way or another, either you 
> can sync to home/bert/LP1532611 or we could declare the edits in that 
> branch premature and restart it with a new patch from you).  You can 
> then send patches to whoever owns the branch so people can track it.
>

I will post all fixes to the existing LP as additional patches. Once 
patch is published, I will not modify it or recall it.

I am not very comfortable with the proposed development model (spread 
patches over various private branches) as I do not see clear way from 
bug report (with patch added) to its merging to master branch.

Milan


> Britton
>


--------------020106010703000308020505
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by angua.bastl.sk id u0GBjcia004083

<html>
  <head>
    <meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Ty=
pe">
  </head>
  <body bgcolor=3D"#FFFFFF" text=3D"#000000">
    <div class=3D"moz-cite-prefix">On 15. 1. 2016 2:51, Britton Kerin
      (<a class=3D"moz-txt-link-abbreviated" href=3D"mailto:britton.kerin=
@gmail.com">britton DOT kerin AT gmail DOT com</a>) [via <a class=3D"moz-txt-link-ab=
breviated" href=3D"mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a=
>] wrote:<br>
    </div>
    <blockquote
cite=3D"mid:CAC4O8c93jC=3DqRPAHnzBCrVYONGnyvQ55qv5yQ-vor8es-0_meg AT mail DOT gm=
ail.com"
      type=3D"cite">
      <div dir=3D"ltr"><br>
        <div class=3D"gmail_extra">
          <div class=3D"gmail_quote">On Thu, Jan 14, 2016 at 2:20 PM,
            Milan Prochac (<a moz-do-not-send=3D"true"
              href=3D"mailto:milan AT prochac DOT sk">milan AT prochac DOT sk</a>) [via
            <a moz-do-not-send=3D"true"
              href=3D"mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com=
</a>]
            <span dir=3D"ltr">&lt;<a moz-do-not-send=3D"true"
                href=3D"mailto:geda-user AT delorie DOT com" target=3D"_blank">g=
eda-user AT delorie DOT com</a>&gt;</span>
            wrote:<br>
            <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex"><span
                class=3D"">On 12. 1. 2016 20:23, Britton Kerin (<a
                  moz-do-not-send=3D"true"
                  href=3D"mailto:britton DOT kerin AT gmail DOT com" target=3D"_blan=
k"><a class=3D"moz-txt-link-abbreviated" href=3D"mailto:britton DOT kerin AT gma=
il.com">britton DOT kerin AT gmail DOT com</a></a>)
                [via <a moz-do-not-send=3D"true"
                  href=3D"mailto:geda-user AT delorie DOT com" target=3D"_blank"=
>geda-user AT delorie DOT com</a>]
                wrote:<br>
                <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">
                  <br>
                  I'm working on this branch there are some minor
                  issues.=C2=A0 I'll push fixes to LP1532611_fixes<br>
                  <br>
                </blockquote>
                <br>
              </span>
              Can you share details about the issues? I guess I can
              identify the culprit and prepare fix faster<br>
            </blockquote>
            <div><br>
            </div>
            <div style=3D"">Attached is a patch showing roughly what I've
              found.=C2=A0 The fftemplate.c is entirely in this patch but=
 I
              didn't change anything in it besides including assert.h I
              think.</div>
            <div style=3D""><br>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    The "patch" is not readable/applicable. Can you please provide the
    copy without color ANSI sequences?<br>
    <br>
    <blockquote
cite=3D"mid:CAC4O8c93jC=3DqRPAHnzBCrVYONGnyvQ55qv5yQ-vor8es-0_meg AT mail DOT gm=
ail.com"
      type=3D"cite">
      <div dir=3D"ltr">
        <div class=3D"gmail_extra">
          <div class=3D"gmail_quote">
            <div style=3D"">It comes down to a little more honoring of
              default format (e.g. making sure its in default position
              in format list in SaveAs, checks that only one defualt
              format is specified, and stuff to take care of situation
              where PCB-&gt;Filename is known and PCB-&gt;Fileformat
              not.=C2=A0 Some or all of that last category of change may =
be
              uneeded with the patch you propose for invalid file
              arguments (which I think is the right fix for that).=C2=A0<=
/div>
            <div>=C2=A0</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    I will review my changes and ensure that PCB-&gt;Fileformat is valid
    when PCB-&gt;Filename is known. The assignment of filename from
    commandline was missed, but all other situations should be handled
    properly.<br>
    <br>
    Please note that patch LP1534373 is for PCB without modular file
    format. It will require one more line to support modular formats -
    set the default format along with filename of non-existing board.<br>
    <br>
    <blockquote
cite=3D"mid:CAC4O8c93jC=3DqRPAHnzBCrVYONGnyvQ55qv5yQ-vor8es-0_meg AT mail DOT gm=
ail.com"
      type=3D"cite">
      <div dir=3D"ltr">
        <div class=3D"gmail_extra">
          <div class=3D"gmail_quote">
            <div style=3D"">I'd like for you to "own" this code for sure
              as you can almost surely improve it faster and better, but
              I'd like to start using it as well.=C2=A0 If you aren't wan=
ting
              to use git yet it would be nice to get you synced up with
              a repository version (one way or another, either you can
              sync to home/bert/LP1532611 or we could declare the edits
              in that branch premature and restart it with a new patch
              from you).=C2=A0 You can then send patches to whoever owns =
the
              branch so people can track it.</div>
            <div style=3D""><br>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    I will post all fixes to the existing LP as additional patches. Once
    patch is published, I will not modify it or recall it.<br>
    <br>
    I am not very comfortable with the proposed development model
    (spread patches over various private branches) as I do not see clear
    way from bug report (with patch added) to its merging to master
    branch. <br>
    <br>
    Milan<br>
    <br>
    <br>
    <blockquote
cite=3D"mid:CAC4O8c93jC=3DqRPAHnzBCrVYONGnyvQ55qv5yQ-vor8es-0_meg AT mail DOT gm=
ail.com"
      type=3D"cite">
      <div dir=3D"ltr">
        <div class=3D"gmail_extra">
          <div class=3D"gmail_quote">
            <div style=3D"">Britton</div>
          </div>
          <br>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>

--------------020106010703000308020505--