X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=fWwLwwGAiZPg6pK/FZDYR3NWq91PIn3yHFlKjs4Cyvs=; b=yEZ1uiKXE2PVLZOVuV3uduXFm8feDMP6JrNiav8agXaVf8BHsxj+PY0pg/P2ZtxxwG U/N5wXowHnYey0efMgLErVzx4UpxKmuy0RegaQknykesudwgQFqVb+ZDEl95ljAWvQAW rrhjWAGNlCeV7hy50z2/zZHuKw01iW3P8pYOCZp3wxF9OfnVlzne+j3GiazM00wXh6L1 rMnQHuY1dvX/FGP+IDW8nDXLZ885GtBY/rhV9tSoiYNcBwrp6NP1WJiyFbVA7yfaPwvL thSPGPftwVOK5rNCw2YT2ZdsaA5RN08K76nJdad3OoJ69lOQfC4ddI+1mC0q52ombx9b Fthg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=fWwLwwGAiZPg6pK/FZDYR3NWq91PIn3yHFlKjs4Cyvs=; b=ZqG6BwhHKb9tR8Q7sVYpdGsgDef2nRwODnhgKKAKV8lSHW1mHih8VjF/tKBNKPLORL 9FZo62zsGhZt8wqzLRR+f98KF5dWQmA3OQiq/hrecUifGUHYkwY132B/z3zav1+kTwog j5gkY6wAnpBP0UYTfXybh2J8W/3QYsFE806G+bqc0NvvXa4Psi7x0Eq+DQKwrq+pOTDG s6sxuB4qg1TVlcIvp3xhgNZ7oJ+6mdr47LliwFdvJ+6KtxgXLtA7rJ983zNxvrWEQgSr Keflf8FeFGNUqXmsKV1wvnvFZSD0efuV6AXYdKfHuYsgGudKlchgyK0JrYkLU7/NpYy4 hZsg== X-Gm-Message-State: AG10YOTHZ3YR92lGBSL911BrtkJNXn9HIZnz2dEJW/DPyXj8iyZJoWodVJxR3UvfVO5Yqk437DFqOWcdqANxfg== MIME-Version: 1.0 X-Received: by 10.28.48.131 with SMTP id w125mr817351wmw.18.1452895720930; Fri, 15 Jan 2016 14:08:40 -0800 (PST) In-Reply-To: <20160115221555.f0a13b6d52b63876b734d3a3@gmail.com> References: <20160115221555 DOT f0a13b6d52b63876b734d3a3 AT gmail DOT com> Date: Fri, 15 Jan 2016 13:08:40 -0900 Message-ID: Subject: Re: [geda-user] pcb DRC and clearance From: "Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" To: geda-user AT delorie DOT com Content-Type: multipart/alternative; boundary=001a114242a457871b052966a5fc Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk --001a114242a457871b052966a5fc Content-Type: text/plain; charset=UTF-8 On Fri, Jan 15, 2016 at 12:15 PM, Nicklas Karlsson ( nicklas DOT karlsson17 AT gmail DOT com) [via geda-user AT delorie DOT com] < geda-user AT delorie DOT com> wrote: > I had an hour two to spend on DRC check. In the attached file "find." the > drcall(...) function was quite long so I broke out the different loops into > separate functions. The variables where reused in each loop but I think > everything is OK except one row info.flag = SELECTEDFLAG; which I suspect > is used for something. > I have changes in this function. I've been trying to get it merged to something for a while now, as I'd really rather not do big nasty merges if they can be avoided. If you take a look at home/bkerin/warn_about_invalid_flags you'll get my latest version of this file. A simpler alternative would be to hold off a bit on any cleanup here until I can get this branch merged. Any refactoring of DRCAll counts as scary, as there are lots of globals and setjmp points lurking around there. Changed file is attached, do anybody if the row info.flag = SELECTEDFLAG; > is needed? > I don't know for sure but DRCAll definitely makes heavy use of SELECTEDFLAG to do it's thing, if you have any doubt about something like that I wouldn't change anything. > Interestingly enough the attached source code also contained the name of a > rather hot place down under which caught the attention of the anti spam > filter. > > > To implement clearance value per net I need to find all copper objects > connected to each net. It is possible to select nets with the "PCB Netlist" > dialog in pcb. Can anybody give a hint about there the code to find the > nets are located? > The only way I know about is how DoIt() in find.c does it. There may be a separate implementation with a different overall purpose lurking elsewhere, I don't know. Britton --001a114242a457871b052966a5fc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Jan 15, 2016 at 12:15 PM, Nicklas Karlsson (nicklas DOT karlsson17 AT gmail DOT com) [via geda-user AT delorie DOT com] <geda-use= r AT delorie DOT com> wrote:
I had an hour two t= o spend on DRC check. In the attached file "find." the drcall(...= ) function was quite long so I broke out the different loops into separate = functions. The variables where reused in each loop but I think everything i= s OK except one row info.flag =3D SELECTEDFLAG; which I suspect is used for= something.

I have changes in this= function.=C2=A0 I've been trying to get it merged to something for a w= hile now, as I'd really rather not do big nasty merges if they can be a= voided.

If you take a look at home/bkerin/warn_abo= ut_invalid_flags you'll get my latest version of this file.=C2=A0 A sim= pler alternative would be to hold off a bit on any cleanup here until I can= get this branch merged.

Any refactoring of DRCAll= counts as scary, as there are lots of globals and setjmp points lurking ar= ound there.

Changed file is attached, do anybody if the row info.flag =3D SELECTEDFLAG;= is needed?

I don't know for s= ure but DRCAll definitely makes heavy use of SELECTEDFLAG to do it's th= ing, if you have any doubt about something like that I wouldn't change = anything.
=C2=A0
Interestingly enough the attached source code also contained the name of a = rather hot place down under which caught the attention of the anti spam fil= ter.


To implement clearance value per net I need to find all copper objects conn= ected to each net. It is possible to select nets with the "PCB Netlist= " dialog in pcb. Can anybody give a hint about there the code to find = the nets are located?

The only way I kn= ow about is how DoIt() in find.c does it.=C2=A0 There may be a separate imp= lementation with a different overall purpose lurking elsewhere, I don't= know.

Britton
--001a114242a457871b052966a5fc--