X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Tue, 22 Dec 2015 19:45:19 +0100
From: Martin Beranek <martin AT mb5 DOT cz>
To: "Peter Clifton (petercjclifton AT googlemail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Subject: Re: [geda-user] Self-intersecting polygon appears because of
 intersection coordinates rounding
Message-ID: <20151222184519.GO14853@abax>
References: <20151222144719 DOT GN14853 AT abax>
 <CAJXU7q9yKKheYd5fnQz=cax=+rMmjDGNCuojLquq6zsiYZmRxw AT mail DOT gmail DOT com>
 <CAJXU7q9ufwTHKAZf2Dp-_S5FpAs5BmJSPatrWnCi8uCXmPeyVg AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJXU7q9ufwTHKAZf2Dp-_S5FpAs5BmJSPatrWnCi8uCXmPeyVg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Hi Peter,

> I'd be interested to know how you got on running your board against
> this old branch of mine:
> 
> http://www.repo.or.cz/geda-pcb/pcjc2.git/shortlog/refs/heads/for_master2

OK, tested now. Compiling from this branch directly, I do not have this
problem on my test board, but there is a lot of changes including
size/shape of the clearout around lines/pads as it looks like (I did not
analyzed things in details yet, but it seems that coordinates of
polygon vertices are slightly different).

So I decided to take polygon1.c only and transplant it into the main pcb
branch. Now, it seems that the buggy intersection calculation happens,
but without any adverse effect on polygon rendering. It seems that order
of collecting is different because of other changes and the collect does
not run over problematic edges.

But with small modification (letting ground fill into one previously
clear area), I was able to make polygon disappear after component move
in almost the same way as in the main branch.

I do not have enough debug info processed yet, so it is maybe another
vertex/edge causing the bug this time.


While I was not able to reproduce the issue with the clean pcb version from
your branch, I believe it is not fixed there, it would just occur for
some different layout as lot of things related to polygons is changed
and I am not getting the 'right' vortices (coordinates) there with my
test board.



Martin