X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=ykp+ViETy74nxKXCZoNBUzttAAcxM0SFszZjIjAYtbk=;
        b=dhVSY6m85tGQO3n1+j0NwjslgKU6nRo3VuO1arSqN4+crYVlbS4zX2MZ4fNjZWgdgq
         C3JpzJHhjObzeycRHzL0A+u9WuVuYgYb1yrL125YCkkCV4q1xUZ8irbBe3a8Gl11M0y+
         SWdkGdAEwjnD5QZYObhb/0f8vP8ta28xg/d4acqey53TtaV9FcV3mDSEIrCDlgXpQuAE
         1drVzapHwnu0NdjULZNsykpPifOqarIylWdne6PVx74uHKyvq8E48U/DpGVS7g7q9u2+
         UZzyCt7zwmhl+Jnyhe8MmdnbHJ+GUQFr5HjOhLxT3+O9USzx1PTv06oT9cWKzJbkq9cb
         E9fw==
MIME-Version: 1.0
X-Received: by 10.194.6.98 with SMTP id z2mr10486026wjz.101.1450556859470;
 Sat, 19 Dec 2015 12:27:39 -0800 (PST)
In-Reply-To: <201512152309.tBFN90dS016514@envy.delorie.com>
References: <CAC4O8c_Jc98kmjDp_O2hKbY9BWWAjGk+nb0L5L=jqXfeTAYGGA AT mail DOT gmail DOT com>
	<201512152309 DOT tBFN90dS016514 AT envy DOT delorie DOT com>
Date: Sat, 19 Dec 2015 11:27:39 -0900
Message-ID: <CAC4O8c_JOuRoV3bc8St49A6_LWkjfEMwY21mgwLZ8RgjdmszQQ@mail.gmail.com>
Subject: Re: [geda-user] merge please (or rebase if you must)
From: "Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Content-Type: multipart/alternative; boundary=047d7b5d3e6455e0980527461683
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

--047d7b5d3e6455e0980527461683
Content-Type: text/plain; charset=UTF-8

I think all these issues are taken care of now except the C99 compiler
tests.
I pushed to home/bkerin/fix_drc_violation_locations again

On Tue, Dec 15, 2015 at 2:09 PM, DJ Delorie <dj AT delorie DOT com> wrote:

>
> PCB does support width!=height arcs, for example, the gerber HID has
> special code for drawing them.  Why are we removing support for them?
>
> I note you use // for comments.  If we're going this route, we should
> update configure to test for a C99-compliant compiler.
>
> arcs with square ends - yeah, we can probably ignore those.  Although
> it's better to keep the arcs (and drop the square end flag) than drop
> the arc completely.
>
> In many cases in the geometry module, you use Vec where you mean
> Point.  Granted, the data is the same, but the meanings should be
> clear to the user, since it's part of the "documentation".
>
> I think the debug markers should either be removed for now, or
> "completed" - added to all HIDs and documented with some
> programmer-specific documentation.
>
> has_flag() shouldn't be needed as the parser converts strings on read.
>
> The right way to ignore square flags on arcs is to update the flag
> parsing table so that it's not in the supported flags... oh wait, it's
> already ignored there.
>
> Rather than check for zero-sized arcs, check for non-positive-sized arcs.
>
> Foo foo foooo, twice.  With an abort, no less.
>
> "double" type isn't precise enough to hold a pcb coord - "double" is
> 53 bits, but Coord is 64 bits.  Does this matter?
>
> You left debugging enabled in search.c
>

--047d7b5d3e6455e0980527461683
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div style=3D"">I think all these issues are taken car=
e of now except the C99 compiler tests.</div><div style=3D"">I pushed to ho=
me/bkerin/fix_drc_violation_locations again</div></div><div class=3D"gmail_=
extra"><br><div class=3D"gmail_quote">On Tue, Dec 15, 2015 at 2:09 PM, DJ D=
elorie <span dir=3D"ltr">&lt;<a href=3D"mailto:dj AT delorie DOT com" target=3D"_b=
lank">dj AT delorie DOT com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex=
"><br>
PCB does support width!=3Dheight arcs, for example, the gerber HID has<br>
special code for drawing them.=C2=A0 Why are we removing support for them?<=
br>
<br>
I note you use // for comments.=C2=A0 If we&#39;re going this route, we sho=
uld<br>
update configure to test for a C99-compliant compiler.<br>
<br>
arcs with square ends - yeah, we can probably ignore those.=C2=A0 Although<=
br>
it&#39;s better to keep the arcs (and drop the square end flag) than drop<b=
r>
the arc completely.<br>
<br>
In many cases in the geometry module, you use Vec where you mean<br>
Point.=C2=A0 Granted, the data is the same, but the meanings should be<br>
clear to the user, since it&#39;s part of the &quot;documentation&quot;.<br=
>
<br>
I think the debug markers should either be removed for now, or<br>
&quot;completed&quot; - added to all HIDs and documented with some<br>
programmer-specific documentation.<br>
<br>
has_flag() shouldn&#39;t be needed as the parser converts strings on read.<=
br>
<br>
The right way to ignore square flags on arcs is to update the flag<br>
parsing table so that it&#39;s not in the supported flags... oh wait, it&#3=
9;s<br>
already ignored there.<br>
<br>
Rather than check for zero-sized arcs, check for non-positive-sized arcs.<b=
r>
<br>
Foo foo foooo, twice.=C2=A0 With an abort, no less.<br>
<br>
&quot;double&quot; type isn&#39;t precise enough to hold a pcb coord - &quo=
t;double&quot; is<br>
53 bits, but Coord is 64 bits.=C2=A0 Does this matter?<br>
<br>
You left debugging enabled in search.c<br>
</blockquote></div><br></div>

--047d7b5d3e6455e0980527461683--