X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Message-ID: <20151217115354.19720.qmail@stuge.se>
Date: Thu, 17 Dec 2015 12:53:54 +0100
From: "Peter Stuge (peter AT stuge DOT se) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] merge please (or rebase if you must)
Mail-Followup-To: geda-user AT delorie DOT com
References: <CAC4O8c_Jc98kmjDp_O2hKbY9BWWAjGk+nb0L5L=jqXfeTAYGGA AT mail DOT gmail DOT com> <201512152309 DOT tBFN90dS016514 AT envy DOT delorie DOT com> <CAC4O8c8jaeiyrD4eEcWAR69GC=nd__gBLfPtstNUfQDAstvBcA AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAC4O8c8jaeiyrD4eEcWAR69GC=nd__gBLfPtstNUfQDAstvBcA@mail.gmail.com>
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com] wrote:
> > I note you use // for comments.  If we're going this route, we should
> > update configure to test for a C99-compliant compiler.
> 
> This is probably a pretty safe assumption now.

It isn't, among other platforms for the sake of Windows.

Please do not make comments cause a dependency on a C99 compiler if
nothing else does. Please do stick with /* the classic style */


> > In many cases in the geometry module, you use Vec where you mean
> > Point.  Granted, the data is the same, but the meanings should be
> > clear to the user, since it's part of the "documentation".
> 
> It bugs me too.  The C alternatives I'm aware of are:
> 
>   * use casts wherever a conversion happens.  Not sure how ugly it would
>     get in this particular case

If there are two types then two macros are needed to do the two
possible conversions and if they have reasonable names then it isn't
very ugly at all.


Thank you for your work!


//Peter