> I note= you use // for comments.=C2=A0 If we're going this route, we should

> update configure to test for a C99-compl= iant compiler.

This is probably a pretty safe assumption now.

> arcs with square end= s - yeah, we can probably ignore those.=C2=A0 Although

> it's better to keep the arcs (and drop the square end = flag) than drop

> the arc completely.

Ok.

> In ma= ny cases in the geometry module, you use Vec where you mean

> Point.=C2=A0 Granted, the data is the same, but the m= eanings should be

> clear to the user, s= ince it's part of the "documentation".

It bugs me too.=C2=A0 The C = alternatives I'm aware of are:

=C2=A0 * use casts wherever a conversion happe= ns.=C2=A0 Not sure how ugly it would

=C2=A0= =C2=A0 get in this particular case but it usually gets ugly pretty fast th= is way

=C2=A0 =C2=A0 I've done similar = stuff the more pedantic way with Vec as another

=C2=A0 =C2=A0 dynamically allocated type and it's so ugly, you end= up with more math bugs

=C2=A0 =C2=A0 from = trying to keep track of it all

=C2=A0 * Change Vec to Tuple so people can't c= omplain :)

> I think the debug markers sh= ould either be removed for now, or

> &qu= ot;completed" - added to all HIDs and documented with some

> programmer-specific documentation.

Would you settle for= stubs in the non-gtk HIDs, and programmer documentation?

It's not obvious to me how to do it in lesstif and I h= ave no real motivation

to figure it out.=C2= =A0 What do you mean by programmer documentation besides

comments in hid.h?

> has_flag() shouldn't be needed as the p= arser converts strings on read.

<= div class=3D"gmail_quote">Yeah it's left-over junk, I'll remove

> The = right way to ignore square flags on arcs is to update the flag

> parsing table so that it's not in the supporte= d flags... oh wait, it's

> already i= gnored there.

I didn't find this table... so I can just take out all the squa= re arc stuff

and it should do the right thi= ng (though a message would be nice really)?

> Rather than check for zero-sized= arcs, check for non-positive-sized arcs.

<= br>

Ok.

> Foo foo foooo, twice.=C2=A0 With an = abort, no less.

Well I was making sure I'd found the arc parser.=C2=A0 Seems = you have some

old-style arcs around

> "do= uble" type isn't precise enough to hold a pcb coord - "double= " is

> 53 bits, but Coord is 64 bit= s.=C2=A0 Does this matter?

Well, the existing geometry code does this = quite a lot.

My system is so old Coord is 32 on it (I guess that's why) and i= t works fine,

so I think it's ok.=C2=A0= It bugs me too though.=C2=A0 In pcb_geometry.h I have this:

// I'd like ensu= re that the floating point type used always be wider than

// the coordinate type, to guarantee that we can go from t= he latter to the

// former without loss, bu= t pcb doesn't do this and it would be a significant

// change to the build requirements.=C2=A0 This would do it:

//_Static_assert (

// =C2=A0 =C2=A0(sizeof (GEOM_DEFAULT_FLOAT_TYPE) > sizeof (Coord= )),

// =C2=A0 =C2=A0"floating point ty= pe for geometry.h not wider than Coord type" );

I'll uncomment that and = use long double if you want, though as a subsequent

poster pointed out it's probably ok precision-wise as it is.

> Yo= u left debugging enabled in search.c

I'll remove it.

Britton

--001a1148e62ab160a50527095eb1--