X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=UcUvH7emGFKhSk8G08SzvYsozweK/ITo9F1+M6C3AWw=;
        b=ZcPT9saXolBbQfE1iS08bs0N5dBkVy2bOwkStJNmkg+ACgTrDkBGD0z82NoU4qId6Q
         7r25j6wd4HpzX8U1hh+tOTORbceHjQI/aZpsIRFJ1WFyGiNAKDxM/J5i3mk0SBbVit5T
         IjSE0LvhkgobHEAeu8i3pnW8+PQzRfACwwWIYkX1G70APO1dwlTsHDHYg1vhDXBFX71g
         2BhH2wIAlQkNicADU2sEUVn8hYJ+V/71moxqPyGP2BTjTQ66O8aa5ADqsu29enGUw/GO
         awqvdG5CIJlW4EFvyegkPoVvoTNBkLhnaFxQgr9w7gcBsdsGXrvEIt2bYGJa97ClbvwY
         n2BA==
MIME-Version: 1.0
X-Received: by 10.194.21.199 with SMTP id x7mr19991130wje.63.1443392474524;
 Sun, 27 Sep 2015 15:21:14 -0700 (PDT)
In-Reply-To: <5606C24E.1070102@jump-ing.de>
References: <CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ AT mail DOT gmail DOT com>
	<55FFCE93 DOT 7070004 AT jump-ing DOT de>
	<CAC4O8c-bZ8F_C9Yt6uspYBQCA+WpA5qfssOhktwrGegsCQVhmw AT mail DOT gmail DOT com>
	<560257D0 DOT 9050906 AT jump-ing DOT de>
	<CAC4O8c8uavK0JyZ_bQfGnrZMnxGGYbn7XjYuwsmxdSPwubZCqg AT mail DOT gmail DOT com>
	<5606C24E DOT 1070102 AT jump-ing DOT de>
Date: Sun, 27 Sep 2015 14:21:14 -0800
Message-ID: <CAC4O8c92VPa81JEqdyHT7qkFfuqPf-hxNtyqqeSSFwZV7xy_WQ@mail.gmail.com>
Subject: Re: [geda-user] DRC violation discovery order fix options
From: "Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Content-Type: multipart/alternative; boundary=047d7b5d95cbb732910520c1ff02
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

--047d7b5d95cbb732910520c1ff02
Content-Type: text/plain; charset=UTF-8

On Sat, Sep 26, 2015 at 8:05 AM, Markus Hitter (mah AT jump-ing DOT de) [via
geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote:

> Am 24.09.2015 um 00:57 schrieb Britton Kerin:
>
> > Ok spaces and C++ style comments are gone.
>
> Thanks. Squashed these two commits and put them onto branch LP1500042 to
> allow both of us to edit the branch. After squashing it became visible
> what the intentions are. :-)
>
> Also opened a bug for it: https://bugs.launchpad.net/bugs/1500042
>
> In pan_common() in gtkhid-main.c you remove two coordinate conversions.
> It appears to be unrelated to your other work. The person putting these
> conversions there likely had a reason to do so. If you're sure this can
> be removed it'd be nice to put this into a separate commit and to
> describe the reason.
>

They don't do anything.  The locals event_x/y are just copied out
then straight back into gport->pcb_x/y, none of which are use at all in the
interim

> The things that's gonna strike you as
> > strange is the gdk_window_process_all_updates() in pan_common().  It's
> > because the ghid_invalidate_all() in gtkhid-gl.c is super weird, it has a
> > timer so doesn't process updates as expected for us.  The worst
> consequence
> > is maybe a small efficiency loss.  It could perhaps be done from
> > ghid_set_crosshair() if that's a concern.  It could perhaps also go in
> > ghid_port_ranges_changed(), but for all I know the weird timer is
> intended
> > specifically to make viewport scrolling smooth.  I dunno on this.
>
> This doesn't exactly sound like you understand what you're doing :-)
>

Well, what I'm not doing is trying to fix ghid_invalidate_all :)  I moved
the
gdk_window_process_all_updates to the most inoffensive possible spot,
leaving pan_common still potentially confused on account of the confusion
in ghid_port_ranges_changed, but nothing should be any slower or more
buggy than it was.

Sprint was fun thx for all your help there

--047d7b5d95cbb732910520c1ff02
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Sat, Sep 26, 2015 at 8:05 AM, Markus Hitter (<a href=3D"mailto:mah AT j=
ump-ing.de">mah AT jump-ing DOT de</a>) [via <a href=3D"mailto:geda-user AT delorie DOT c=
om">geda-user AT delorie DOT com</a>] <span dir=3D"ltr">&lt;<a href=3D"mailto:geda=
-user AT delorie DOT com" target=3D"_blank">geda-user AT delorie DOT com</a>&gt;</span> w=
rote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex"><span class=3D"">Am 24.09.2015 um 0=
0:57 schrieb Britton Kerin:<br>
<br>
&gt; Ok spaces and C++ style comments are gone.<br>
<br>
</span>Thanks. Squashed these two commits and put them onto branch LP150004=
2 to<br>
allow both of us to edit the branch. After squashing it became visible<br>
what the intentions are. :-)<br>
<br>
Also opened a bug for it: <a href=3D"https://bugs.launchpad.net/bugs/150004=
2" rel=3D"noreferrer" target=3D"_blank">https://bugs.launchpad.net/bugs/150=
0042</a><br>
<br>
In pan_common() in gtkhid-main.c you remove two coordinate conversions.<br>
It appears to be unrelated to your other work. The person putting these<br>
conversions there likely had a reason to do so. If you&#39;re sure this can=
<br>
be removed it&#39;d be nice to put this into a separate commit and to<br>
describe the reason.<br></blockquote><div><br></div><div style=3D"">They do=
n&#39;t do anything.=C2=A0 The locals event_x/y are just copied out</div><d=
iv style=3D"">then straight back into gport-&gt;pcb_x/y, none of which are =
use at all in the interim =C2=A0</div><div style=3D""><br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc soli=
d;padding-left:1ex"><span class=3D"">
&gt; The things that&#39;s gonna strike you as<br>
&gt; strange is the gdk_window_process_all_updates() in pan_common().=C2=A0=
 It&#39;s<br>
&gt; because the ghid_invalidate_all() in gtkhid-gl.c is super weird, it ha=
s a<br>
&gt; timer so doesn&#39;t process updates as expected for us.=C2=A0 The wor=
st consequence<br>
&gt; is maybe a small efficiency loss.=C2=A0 It could perhaps be done from<=
br>
&gt; ghid_set_crosshair() if that&#39;s a concern.=C2=A0 It could perhaps a=
lso go in<br>
&gt; ghid_port_ranges_changed(), but for all I know the weird timer is inte=
nded<br>
&gt; specifically to make viewport scrolling smooth.=C2=A0 I dunno on this.=
<br>
<br>
</span>This doesn&#39;t exactly sound like you understand what you&#39;re d=
oing :-)<br></blockquote><div><br></div><div style=3D"">Well, what I&#39;m =
not doing is trying to fix ghid_invalidate_all :) =C2=A0I moved the</div><d=
iv style=3D"">gdk_window_process_all_updates to the most inoffensive possib=
le spot,</div><div style=3D"">leaving pan_common still potentially confused=
 on account of the confusion</div><div style=3D"">in ghid_port_ranges_chang=
ed, but nothing should be any slower or more</div><div style=3D"">buggy tha=
n it was. =C2=A0</div><div>=C2=A0</div><div style=3D"">Sprint was fun thx f=
or all your help there</div><div style=3D""><br></div></div></div></div>

--047d7b5d95cbb732910520c1ff02--