X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=bHi2/IN+Sxu57n4uMvRACfzK6M9YdpPZQpfCxtO5cxA=;
        b=RZfQ4JXHvlWlSDqo+aU56f6RQtLhhOHrUXuLwd2sol0pYiE7d1nz3QrgweTayXAL3i
         x8bmsGR2jqflZbnAfntMuaQUxn1HcTEj00M5GbNvawWTjGds1tz+2AfojHpizrz84FFD
         nT7tRZZTPTeZFKRz1VbpFENZsD4fzxEN3Z6rmOgrVU4IoLcLQKEhLZdZtkmvZnDrhmU6
         3xwWw8Q+jQ5JE97wbQ8UrJeyH8bkRZzhdTwbfPqr0V7b3mtbFe9+377byxp7PabznrTL
         vbYvGGVZO28c4V6/O2IayhLc2wtpAkpeejP+eItZ4cDOIW31R+zOPm6WRamzPEvr4KQm
         SWiw==
MIME-Version: 1.0
X-Received: by 10.194.223.68 with SMTP id qs4mr3993307wjc.38.1442961837050;
 Tue, 22 Sep 2015 15:43:57 -0700 (PDT)
In-Reply-To: <55FFCE93.7070004@jump-ing.de>
References: <CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ AT mail DOT gmail DOT com>
	<55FFCE93 DOT 7070004 AT jump-ing DOT de>
Date: Tue, 22 Sep 2015 14:43:57 -0800
Message-ID: <CAC4O8c-bZ8F_C9Yt6uspYBQCA+WpA5qfssOhktwrGegsCQVhmw@mail.gmail.com>
Subject: Re: [geda-user] DRC violation discovery order fix options
From: "Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Content-Type: multipart/alternative; boundary=001a11c3ab7ab8d1ef05205dbb45
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

--001a11c3ab7ab8d1ef05205dbb45
Content-Type: text/plain; charset=UTF-8

On Mon, Sep 21, 2015 at 1:32 AM, Markus Hitter (mah AT jump-ing DOT de) [via
geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote:

> Am 20.09.2015 um 02:11 schrieb Britton Kerin:
> > well reordering the DRC violations is hard due [...]
>
> I've looked at the commit you pushed. Difficult to review, because it
> does at least three things in one commit:
>
> - Lots of whitespace editing (removal of whitespace at line ends).
>

I can go back and fix this, I agree it can be annoying.


> - Change something in main.c.
>
> - Change something in the HID.
>

These changes are mostly connected.  Without the hid change the other is
broken, the hid change by itself is pointless.  The change in
lesstif/main.c documents the fact that the hid behavior isn't implemented
there yet, so a fallback is used.

The gui-drc-window.c could be considered separate, though without it things
might not work gracefully at all in some window managers.

I like small commits too but they must work right, and after some effort I
think this is the smallest set of changes that solve this issue.  It got
the new hid option to avoid changing code visible to users as an Action
(I'm pretty sure its not right but someone might be using it as it is).  I
guess the hid change could get its own commit but it wouldn't be one you
would ever want to leave in as it would just add dead code.

Besides fixing spaces how would you change it?

--001a11c3ab7ab8d1ef05205dbb45
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Mon, Sep 21, 2015 at 1:32 AM, Markus Hitter (<a href=3D"mailto:mah AT j=
ump-ing.de">mah AT jump-ing DOT de</a>) [via <a href=3D"mailto:geda-user AT delorie DOT c=
om">geda-user AT delorie DOT com</a>] <span dir=3D"ltr">&lt;<a href=3D"mailto:geda=
-user AT delorie DOT com" target=3D"_blank">geda-user AT delorie DOT com</a>&gt;</span> w=
rote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex">Am 20.09.2015 um 02:11 schrieb Brit=
ton Kerin:<br>
&gt; well reordering the DRC violations is hard due [...]<br>
<br>
I&#39;ve looked at the commit you pushed. Difficult to review, because it<b=
r>
does at least three things in one commit:<br>
<br>
- Lots of whitespace editing (removal of whitespace at line ends).<br></blo=
ckquote><div><br></div><div style=3D"">I can go back and fix this, I agree =
it can be annoying.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Change something in main.c.<br>
<br>
- Change something in the HID.<br></blockquote><div><br></div><div style=3D=
"">These changes are mostly connected.=C2=A0 Without the hid change the oth=
er is broken, the hid change by itself is pointless.=C2=A0 The change in le=
sstif/main.c documents the fact that the hid behavior isn&#39;t implemented=
 there yet, so a fallback is used.</div><div style=3D""><br></div><div styl=
e=3D"">The gui-drc-window.c could be considered separate, though without it=
 things might not work gracefully at all in some window managers.</div><div=
 style=3D""><br></div><div style=3D"">I like small commits too but they mus=
t work right, and after some effort I think this is the smallest set of cha=
nges that solve this issue.=C2=A0 It got the new hid option to avoid changi=
ng code visible to users as an Action (I&#39;m pretty sure its not right bu=
t someone might be using it as it is).=C2=A0 I guess the hid change could g=
et its own commit but it wouldn&#39;t be one you would ever want to leave i=
n as it would just add dead code.</div><div style=3D""><br></div><div style=
=3D"">Besides fixing spaces how would you change it?</div></div></div></div=
>

--001a11c3ab7ab8d1ef05205dbb45--