X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Wed, 12 Nov 2014 15:32:24 +0100 (CET)
From: Roland Lutz <rlutz AT hedmen DOT org>
To: Eugene Mikhantiev <mikhantiev AT gmail DOT com>, geda-user AT delorie DOT com
Subject: Re: [geda-user] PCB make distcheck
In-Reply-To: <CAHdUXz+4GPP3awzhD+JADei_106HaU6p7CDxNDYYMRob5e-oeg@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1411121532190.21802@home.local>
References: <CAHdUXz+4GPP3awzhD+JADei_106HaU6p7CDxNDYYMRob5e-oeg AT mail DOT gmail DOT com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-412546149-1415802744=:21802"
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-412546149-1415802744=:21802
Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Wed, 12 Nov 2014, Eugene Mikhantiev wrote:
> First, there are typo in tests/golden/hid_png3/Makefile.am. Patch attached.

Thank you for providing a patch!  I applied it to the master branch 
(taking the liberty to replace the spaces with a tabulator to match the 
other test makefiles).

> Second, some tests are failed. Test log attached.

The tests hid_gcode4 and hid_gcode6 didn't fail for me…

> So question is: is this tests critical?

Maybe.  The point with these tests is that they detect silently introduced 
bugs which cause PCB to produce a different output for some given input 
files.  These changes might or might not break the files, but it is 
definitively something that should be investigated further.

Roland

--8323329-412546149-1415802744=:21802--