MIME-Version: 1.0
In-Reply-To: <20140516130935.CAC808020178@turkos.aspodata.se>
References: <CAE8JAfwrwA6tW3TxY64pw7TL96_fAtjyfXTq5tRPC0C0ic9s1A AT mail DOT gmail DOT com>
	<20140516130935 DOT CAC808020178 AT turkos DOT aspodata DOT se>
Date: Sat, 17 May 2014 13:47:50 +0800
Message-ID: <CAE8JAfxxERumHLXNZCKBUzpQPAehuYOG6gVQG7OEs1C=ath8rw@mail.gmail.com>
Subject: Re: [geda-user] Some improvement to gmk_sym
From: Yanjun Yang <yangyj DOT ee AT gmail DOT com>
To: geda-user AT delorie DOT com
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
Precedence: bulk

On Fri, May 16, 2014 at 9:09 PM,  <karl AT aspodata DOT se> wrote:
> Yanjun Yan:
>> I don't know how many users of gmk_sym are out there, I found it quite simple
>> and straight forwards to use.
>
> You know that there are a few symbol generators out there:
>
>  http://www.gedasymbols.org/user/dj_delorie/tools/djboxsym.html
>  http://wiki.geda-project.org/geda:tragesym_readme
>  http://turkos.aspodata.se/git/openhw/pdftosym/pintosym.pl (my projekt)
>
> Try them and see what you can improve.

They are all nice symbol generators, I only looked into tragesym which
comes with the gaf source.  I chose gmk_sym because it seems unmaintained
and the grammer is very simple.

>
> You have not documented what -c means, from the code it seems to set
> ccwise to 1, and that option has a somewhat confusing effect, it seems
> to change only the top and right side order.

I should document -c is for counter-clockwise, which make sense for most chip

>
> Instead of requiring users to specify:
> /*     4th value: box's hoz size, in pins spacings                       */
> /*     5th value: box's ver size, in pins spacings                       */
> /*     8th value: Total number of pins on device (including hidden)      */
> why not just count the number of pins on each side and calculate the
> above values by the program ?
>
> The sym file created contains the attributes pins and class. I cannot
> find them at http://wiki.geda-project.org/geda:master_attributes_list.
> What is your inteded use of them ?
>
> Your resulting sym file has a box:
>  B 300 300 9300 9000 3 0 0 0 -1 -1 0 -1 -1 -1 -1 -1
> with a line width of 0. I like a thicker outline to make it differ from
> nets and such. Wouldn't a line width like 40 be nice ?
>
> There seems not much of a consensus of what grid to place pins on. You
> are using 300, I'm using 400, and symbols in geda repository are using
> a 200, 300 or a 400 grid. Any thoughts ?
>
> In the sym, you have:
>  T 4423 4800 3 10 1 0 0 0 1
>  C8051F020
> Would'n it be nicer to make that an value=C8051F020 attribute ?
>

These are all good advices, I just touched about one third of the original
code, a lot can be done to make it a better tool, thanks for all your
valued opinions.

> Regards,
> /Karl Hammar
>
> -----------------------------------------------------------------------
> Aspö Data
> Lilla Aspö 148
> S-742 94 Östhammar
> Sweden
> +46 173 140 57
>
>