X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h= mime-version:in-reply-to:references:content-type:message-id :content-transfer-encoding:from:subject:date:to; s=beta; bh=bOJn eMAGLoCiY40O90JOkHqAFz1I5sVuVgbEYYx+lTU=; b=Gt6sEr2WEpEKZtJmJGJ1 rAJZgtNoC6CTImtlToHMXDhKtO6tJSoI+ToVpo88ZOq6haiSC9xQRV8S0KYo2IlM Q+kbuV+ggQ1Ymvu9dYonq2H2/BbPBWP4uG8VLQguiluyZFa/ZofDmDwXtJxDLkgL +XI3S/GUFhY9eidZRUssoc4= Mime-Version: 1.0 (Apple Message framework v753.1) In-Reply-To: References: <20130724164522 DOT 311d7f3d AT warrawoona DOT sti> Content-Type: text/plain; charset=UTF-8; delsp=yes; format=flowed Message-Id: From: Markus Hitter Subject: Re: [geda-user] Redundant drawing functions in libgedacairo Date: Tue, 30 Jul 2013 12:52:31 +0200 To: geda-user AT delorie DOT com X-Mailer: Apple Mail (2.753.1) Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id r6UAq58H017500 Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk Likely. Still it might be a good idea to use the same "object" for both for less maintenance and smaller code. Judging by just the function names it sounds like it's just a wrapper around some Cairo feature to allow for different frontends. Launchpad issues are always welcome, Alexey. Especially ones with patch attached. Markus Am 29.07.2013 um 11:14 schrieb Vladimir Zhbanov: > AIUI, it is made to let developers change any primitive > independently of others. gschem and libgeda have always had kind > of object oriented structure and new gEDA libraries and programs > just follow it. > > > 2013/7/24, Alexey Shaposhnikov : >> >> While hacking libgeda i found, that functions >> eda_renderer_draw_line, >> eda_renderer_draw_net, eda_renderer_draw_bus and >> eda_renderer_draw_pin in >> libgedacairo actually repeat each other. The only difference is >> that the >> first >> function takes the values for ​​line width, cap style, dash >> style and dash >> length from object properties, while others use a hard-coded values >> (despite >> all those properties can be set while creating pin, bus or net >> object). >> >> Did i miss something? >> >> -- >> With best regards, Alexey Shaposhnikov. >> >> >> > - - - - - - - - - - - - - - - - - - - Dipl. Ing. (FH) Markus Hitter http://www.jump-ing.de/