X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Envelope-From: paubert AT iram DOT es
Date: Thu, 18 Apr 2013 20:52:46 +0200
From: Gabriel Paubert <paubert AT iram DOT es>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [PATCH 0/3] Improve imperial drill files Gerber
 exporter (and pcb-printf).
Message-ID: <20130418185246.GA7914@visitor2.iram.es>
References: <20130418140806 DOT GA8618 AT gra-vd1 DOT iram DOT es>
 <20130418162031 DOT GB18583 AT malakian DOT lan>
 <20130418175758 DOT GB10466 AT visitor2 DOT iram DOT es>
 <20130418180955 DOT GB19132 AT malakian DOT lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130418180955.GB19132@malakian.lan>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Spamina-Bogosity: Unsure
X-Spam-Score: -1.4 (-)
X-Spam-Report: Content analysis details:   (-1.4 points)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.4 ALL_TRUSTED            Passed through trusted hosts only via SMTP
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Thu, Apr 18, 2013 at 11:09:56AM -0700, Andrew Poelstra wrote:
> On Thu, Apr 18, 2013 at 07:57:59PM +0200, Gabriel Paubert wrote:
> > 
> > To be precise the original redundant check was:
> > 
> >   while (printf_spec[i] == '%' || isdigit(printf_spec[i]) ||
> >          printf_spec[i] == '-' || printf_spec[i] == '+' ||
> >          printf_spec[i] == '#' || printf_spec[i] == '0')
> > 
> > but "is_digit(x)" is a superset of "x == '0'", so I eliminated the latter.
> >
> 
> *facepalm* yes, of course.
>   
> > 
> > > Maybe somebody with more experience with gcode can check over
> > > the gcode changes. But they seem reasonable to me.
> > 
> > Which gcode? I have not touched the gcode exporter AFAIK.
> >
> 
> Oops! I mean't gerber.
>  
> > > 
> > > When I get a chance to check on that check, and assuming no NAK's
> > > come in, I'll push these.
> > 
> > Thanks for taking care of it.
> >
> 
> I'd like somebody more awake than I am to check on it first. ;) 

Don't worry. Tomorrow I'll send a new set taking into account the couple
of remarks I've got. 

This said, make check does not find any error. I have also checked 
a single (simple 2 layer) board, the photoplotter files are identical as expected
(except for the date in the header). The drill files were obviously different,
since the last digit is no more zero. Under gerbv with xor drawing it was 
esaily visible.

This said, there are visible, but minor, differences under gerbv for at least 
text output. I have the same result on 2 machines, so I suspect that the golden
may have to be updated.

	Gabriel