X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Thu, 18 Apr 2013 11:09:56 -0700
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [PATCH 0/3] Improve imperial drill files Gerber
 exporter (and pcb-printf).
Message-ID: <20130418180955.GB19132@malakian.lan>
References: <20130418140806 DOT GA8618 AT gra-vd1 DOT iram DOT es>
 <20130418162031 DOT GB18583 AT malakian DOT lan>
 <20130418175758 DOT GB10466 AT visitor2 DOT iram DOT es>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="xgyAXRrhYN0wYx8y"
Content-Disposition: inline
In-Reply-To: <20130418175758.GB10466@visitor2.iram.es>
User-Agent: Mutt/1.5.21 (2010-09-15)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


--xgyAXRrhYN0wYx8y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2013 at 07:57:59PM +0200, Gabriel Paubert wrote:
>=20
> To be precise the original redundant check was:
>=20
>   while (printf_spec[i] =3D=3D '%' || isdigit(printf_spec[i]) ||
>          printf_spec[i] =3D=3D '-' || printf_spec[i] =3D=3D '+' ||
>          printf_spec[i] =3D=3D '#' || printf_spec[i] =3D=3D '0')
>=20
> but "is_digit(x)" is a superset of "x =3D=3D '0'", so I eliminated the la=
tter.
>

*facepalm* yes, of course.
 =20
>=20
> > Maybe somebody with more experience with gcode can check over
> > the gcode changes. But they seem reasonable to me.
>=20
> Which gcode? I have not touched the gcode exporter AFAIK.
>

Oops! I mean't gerber.
=20
> >=20
> > When I get a chance to check on that check, and assuming no NAK's
> > come in, I'll push these.
>=20
> Thanks for taking care of it.
>

I'd like somebody more awake than I am to check on it first. ;)=20



--=20
Andrew Poelstra
Email: apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew
You create the realities you inhabit.  --Timothy Leary


--xgyAXRrhYN0wYx8y
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQEcBAEBAgAGBQJRcDbzAAoJEHrQqRxAvQCRoX0IAKSOjUKRj6sYf/uprVQo+Eh/
j4Ivg0qQ40IOMBwVPZAXSFFFaZgm98NabjK0hLET3NxWZKMFjgXqHLukI3D0nkgJ
dCpc/IK5/SQbOxO534aVXexn7DpghDAxUDcytWnKGFfCv1TuyyYCWHHKVkNAH9xq
yxPgkDTOxIXC6u6BWiFf2mtYKi73FYSPSuOOniUad/IVWxz0AbT28ZvsRmRkxtPC
9x4YMEfASbrqibvtbaQUKGUKiJDoyRqTdOInB00CzoIhd6Qvt0XdDfe6FyWxhqyz
0GQghps3NO+fXhnUIphfbStXYqWHCn9eV9byJkcGh+kmvCtwiSweWkFXkAX97bg=
=Zac9
-----END PGP SIGNATURE-----

--xgyAXRrhYN0wYx8y--