X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Thu, 18 Apr 2013 10:56:48 -0700
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [PATCH 3/3] Gerber: use 0.1mil resolution for drill
 files.
Message-ID: <20130418175648.GA19132@malakian.lan>
References: <20130418140806 DOT GA8618 AT gra-vd1 DOT iram DOT es>
 <1366294282-8688-1-git-send-email-paubert AT iram DOT es>
 <1366294282-8688-3-git-send-email-paubert AT iram DOT es>
 <20130418161807 DOT GA18583 AT malakian DOT lan>
 <20130418174647 DOT GA10466 AT visitor2 DOT iram DOT es>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z"
Content-Disposition: inline
In-Reply-To: <20130418174647.GA10466@visitor2.iram.es>
User-Agent: Mutt/1.5.21 (2010-09-15)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


--7AUc2qLy4jB3hD7Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2013 at 07:46:47PM +0200, Gabriel Paubert wrote:
> On Thu, Apr 18, 2013 at 09:18:07AM -0700, Andrew Poelstra wrote:
> > On Thu, Apr 18, 2013 at 04:11:21PM +0200, Gabriel Paubert wrote:
> > > ---
> > >  src/hid/gerber/gerber.c |    7 ++++---
> > >  1 file changed, 4 insertions(+), 3 deletions(-)
> > >=20
> > > diff --git a/src/hid/gerber/gerber.c b/src/hid/gerber/gerber.c
> > > index d274afe..cab948b 100644
> > > --- a/src/hid/gerber/gerber.c
> > > +++ b/src/hid/gerber/gerber.c
> > > @@ -697,11 +697,12 @@ gerber_set_layer (const char *name, int group, =
int empty)
> > >  	      Aperture *ap =3D findAperture (curr_aptr_list, pending_drills=
[i].diam, ROUND);
> > >  	      fprintf (f, "T%02d\r\n", ap->dCode);
> > >  	    }
> > > -          /* Notice the last zeroes are literal zeroes here, a x10 s=
cale factor.  *
> > > -           *                                                      v =
       v      */
> > > -	  pcb_fprintf (f, metric ? "X%06.0muY%06.0mu\r\n" : "X%06.0ml0Y%06.=
0ml0\r\n",
> >=20
> >=20
> > I'll be sad to see this comment go ;)
> >=20
> > > +	  pcb_fprintf (f, metric ? "X%06.0muY%06.0mu\r\n" : "X%06.0mtY%06.0=
mt\r\n",
> > >  		   gerberDrX (PCB, pending_drills[i].x),
> > >  		   gerberDrY (PCB, pending_drills[i].y));
> > > +	  printf("Gerber drill X and Y: %ld %ld\n",
> > > +		 gerberDrX (PCB, pending_drills[i].x),
> > > +		 gerberDrY (PCB, pending_drills[i].y));
> >=20
> > Is this just trace code you forgot to remove? Or should it be
> > user visible?
>=20
> My bad, it's trace code. Feel free to remove it or I'll send another patc=
h set. Actually
> it's a residue of a first version in which I had forgotten to add ALLOW_D=
MIL in ALLOW_IMPERIAL
> and all drills appeared at (0,0).=20
>

No worries, I can remove it.

--=20
Andrew Poelstra
Email: apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew


--7AUc2qLy4jB3hD7Z
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQEcBAEBAgAGBQJRcDPgAAoJEHrQqRxAvQCRCoIH/3LgiC2/U6Omjqlg5Vh3BZyg
Cc7tQNfovauioRBZ5FG4SxLiJKP09kaVRZ5qrupnvExJQR5Slls5/k9TkYN1m75r
DoIUFgfG8QN0T5AMQfOhM3C6IDW1uYrk25N9LX5zIJHPLIGYwbNfskekofnDW+k6
iL1CO/6mR37k3KIteXmAMg3ka5KIwc49WwqwsPgqGRQg6HZlx0sisrWrIefrXKfW
D/BPqZsjjPt9nTEaN2pb3SHx5jUHIYnGmJ2ENzcAdAimx4M/7wFc9fLFbi4GXOE5
E1SlOqVNb98huJO8GQ40Xp7lsToxOtgIQvOHqMtGc0RrMCNFnx0avmTMi3i+XzQ=
=oF+8
-----END PGP SIGNATURE-----

--7AUc2qLy4jB3hD7Z--