X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Envelope-From: paubert AT iram DOT es
Date: Thu, 18 Apr 2013 19:46:47 +0200
From: Gabriel Paubert <paubert AT iram DOT es>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [PATCH 3/3] Gerber: use 0.1mil resolution for
 drill files.
Message-ID: <20130418174647.GA10466@visitor2.iram.es>
References: <20130418140806 DOT GA8618 AT gra-vd1 DOT iram DOT es>
 <1366294282-8688-1-git-send-email-paubert AT iram DOT es>
 <1366294282-8688-3-git-send-email-paubert AT iram DOT es>
 <20130418161807 DOT GA18583 AT malakian DOT lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130418161807.GA18583@malakian.lan>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Spamina-Bogosity: Unsure
X-Spam-Score: -1.4 (-)
X-Spam-Report: Content analysis details:   (-1.4 points)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.4 ALL_TRUSTED            Passed through trusted hosts only via SMTP
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Thu, Apr 18, 2013 at 09:18:07AM -0700, Andrew Poelstra wrote:
> On Thu, Apr 18, 2013 at 04:11:21PM +0200, Gabriel Paubert wrote:
> > ---
> >  src/hid/gerber/gerber.c |    7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/hid/gerber/gerber.c b/src/hid/gerber/gerber.c
> > index d274afe..cab948b 100644
> > --- a/src/hid/gerber/gerber.c
> > +++ b/src/hid/gerber/gerber.c
> > @@ -697,11 +697,12 @@ gerber_set_layer (const char *name, int group, int empty)
> >  	      Aperture *ap = findAperture (curr_aptr_list, pending_drills[i].diam, ROUND);
> >  	      fprintf (f, "T%02d\r\n", ap->dCode);
> >  	    }
> > -          /* Notice the last zeroes are literal zeroes here, a x10 scale factor.  *
> > -           *                                                      v        v      */
> > -	  pcb_fprintf (f, metric ? "X%06.0muY%06.0mu\r\n" : "X%06.0ml0Y%06.0ml0\r\n",
> 
> 
> I'll be sad to see this comment go ;)
> 
> > +	  pcb_fprintf (f, metric ? "X%06.0muY%06.0mu\r\n" : "X%06.0mtY%06.0mt\r\n",
> >  		   gerberDrX (PCB, pending_drills[i].x),
> >  		   gerberDrY (PCB, pending_drills[i].y));
> > +	  printf("Gerber drill X and Y: %ld %ld\n",
> > +		 gerberDrX (PCB, pending_drills[i].x),
> > +		 gerberDrY (PCB, pending_drills[i].y));
> 
> Is this just trace code you forgot to remove? Or should it be
> user visible?

My bad, it's trace code. Feel free to remove it or I'll send another patch set. Actually
it's a residue of a first version in which I had forgotten to add ALLOW_DMIL in ALLOW_IMPERIAL
and all drills appeared at (0,0). 

	Regards,
	Gabriel