X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Thu, 18 Apr 2013 09:20:31 -0700
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [PATCH 0/3] Improve imperial drill files Gerber
 exporter (and pcb-printf).
Message-ID: <20130418162031.GB18583@malakian.lan>
References: <20130418140806 DOT GA8618 AT gra-vd1 DOT iram DOT es>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="MfFXiAuoTsnnDAfZ"
Content-Disposition: inline
In-Reply-To: <20130418140806.GA8618@gra-vd1.iram.es>
User-Agent: Mutt/1.5.21 (2010-09-15)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


--MfFXiAuoTsnnDAfZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2013 at 04:08:06PM +0200, Gabriel Paubert wrote:
> 	Hello,
>=20
> I have started fixing a few problems in Gerber exporter:
> - use 0.1mil resolution for drill files (Excellon format)
> - avoid runaway aperture number allocation
>=20
> Since it involved touching pcb-prinf.[ch], I took the opportunity
> to improve comments and perform a couple of cleanups.
>=20
> These patches pass the test suite, this does not mean that no=20
> bugs are introduced, but, loooking at the output under gerbv,
> drills were better centered on pins in the example I tried.
>=20
> I have other patches in the pipeline, but they depend on these
> first 3.
>

Hi Gabriel,


The patches all look good to me. I'll have to look over that
'redundant check' you removed, because it's not clear from the
patch what that check originally did or why it's unnecessary.

Maybe somebody with more experience with gcode can check over
the gcode changes. But they seem reasonable to me.


When I get a chance to check on that check, and assuming no NAK's
come in, I'll push these.



Thanks!,

Andrew

=20

--=20
Andrew Poelstra
Email: apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew


--MfFXiAuoTsnnDAfZ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQEcBAEBAgAGBQJRcB1PAAoJEHrQqRxAvQCRWtsH/22cdqDKBk864PwHFzHR07YT
3SWC+m39LZ6jfEJdb/qd4m9Cz7NUDpCIrz1KK0sZLbhlDqfmHFPC61lWPt9TZgjI
MChvuPUPFx4CtL7UiP/CdFeq5vQXOuQB9ip2gm9qxdw2YI/CCTuXtH9wZaI8uexW
ddf2lJaKs2MhzC5GGFbxC5GLmCz2/PbP+aZxwYCCanJFRMx0RIv61NsgylGs+Ets
Mr+WWJEGmsxBMuo+coskNkPPF0ok/dhJwAOkZpoe4o7YybLpTydANw/EajWiwsLM
iYCq0oIghIG9MFMhy2T2jPd5iYrkn49VTfLoiwZogpqBx4tNuaU1LvnL/4aWtzA=
=gt7b
-----END PGP SIGNATURE-----

--MfFXiAuoTsnnDAfZ--