X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Thu, 18 Apr 2013 09:18:07 -0700
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [PATCH 3/3] Gerber: use 0.1mil resolution for drill
 files.
Message-ID: <20130418161807.GA18583@malakian.lan>
References: <20130418140806 DOT GA8618 AT gra-vd1 DOT iram DOT es>
 <1366294282-8688-1-git-send-email-paubert AT iram DOT es>
 <1366294282-8688-3-git-send-email-paubert AT iram DOT es>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="W/nzBZO5zC0uMSeA"
Content-Disposition: inline
In-Reply-To: <1366294282-8688-3-git-send-email-paubert@iram.es>
User-Agent: Mutt/1.5.21 (2010-09-15)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


--W/nzBZO5zC0uMSeA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 18, 2013 at 04:11:21PM +0200, Gabriel Paubert wrote:
> ---
>  src/hid/gerber/gerber.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/src/hid/gerber/gerber.c b/src/hid/gerber/gerber.c
> index d274afe..cab948b 100644
> --- a/src/hid/gerber/gerber.c
> +++ b/src/hid/gerber/gerber.c
> @@ -697,11 +697,12 @@ gerber_set_layer (const char *name, int group, int =
empty)
>  	      Aperture *ap =3D findAperture (curr_aptr_list, pending_drills[i].=
diam, ROUND);
>  	      fprintf (f, "T%02d\r\n", ap->dCode);
>  	    }
> -          /* Notice the last zeroes are literal zeroes here, a x10 scale=
 factor.  *
> -           *                                                      v     =
   v      */
> -	  pcb_fprintf (f, metric ? "X%06.0muY%06.0mu\r\n" : "X%06.0ml0Y%06.0ml0=
\r\n",


I'll be sad to see this comment go ;)

> +	  pcb_fprintf (f, metric ? "X%06.0muY%06.0mu\r\n" : "X%06.0mtY%06.0mt\r=
\n",
>  		   gerberDrX (PCB, pending_drills[i].x),
>  		   gerberDrY (PCB, pending_drills[i].y));
> +	  printf("Gerber drill X and Y: %ld %ld\n",
> +		 gerberDrX (PCB, pending_drills[i].x),
> +		 gerberDrY (PCB, pending_drills[i].y));

Is this just trace code you forgot to remove? Or should it be
user visible?

>  	}
>        free (pending_drills);
>        n_pending_drills =3D max_pending_drills =3D 0;
> --=20
> 1.7.10.4
>=20

--=20
Andrew Poelstra
Email: apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew
You create the realities you inhabit.  --Timothy Leary


--W/nzBZO5zC0uMSeA
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQEcBAEBAgAGBQJRcBy/AAoJEHrQqRxAvQCRbEsH/1Lq4p6iKw1Gg7InkbWiTG5q
I3B/0MvtwCqcXtzEaakb3t/vTiOY/+bXeRtI6EUpSM6M6C+MrR4iz1NWY4AY2nNA
ZEdFV58ZaSB9E7N5YB3piRmSD9z0w+XDcYwGN7uYVOZahsVkDSTxUCt1IuXAVow3
TR4yq+AtLz7j4e5GdQy4Mq3TZ5eWMzlV8KTOwExkg7U52fGZpKixkNpl5Yth5sfL
BHObT2VRx2mJ2oMrluksnyMQczl8QlSqugiXzY8WYYyQuQcAse774VqejfQ4K4yT
a44LHYShC3TjT9vlkBfRFq1zeomHpCH0eKUgkztM6QoyS0x4860y34gEWV3WCLc=
=mgrP
-----END PGP SIGNATURE-----

--W/nzBZO5zC0uMSeA--