X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:from:date:message-id:subject:to :content-type; bh=GOyfqOmFo8yeuXIWjP/0eQJwvUB4keSjMJzvR68H7QM=; b=Bu5vHw/GmcpvePvv23ap+ZsaLjtu/L4h3ubre/qtVTMR9obILzHwIOE0JXK3+u6x/j 5utuMIF/cK9tfCBYDAzFVFT5DzJO2nuIGcRmcZDt1Md3YQcOhfUkZmpQUEDM29u+6pDZ +ujPPjYrDAa/yD2wlp6Qee4d89ZLzJPh9b8J/YisDafudWCWgBj5I921+rQML3x/qQro fR5e3wHYlLGImHSjLzmuPw8U/ZTt1WQQS3ceyODnI46dMHnv/urheVjgYe1nYRev+qQr kp3ZB4sb9KLYKswbBCB+Pgf77zH4vgSn7qOagC0ttP5vKfUbjF5Y6tGL4eZtmXTlwH6I U7bg== X-Received: by 10.194.158.4 with SMTP id wq4mr3995888wjb.46.1366223170371; Wed, 17 Apr 2013 11:26:10 -0700 (PDT) MIME-Version: 1.0 From: Abhijit Kshirsagar Date: Wed, 17 Apr 2013 23:55:39 +0530 Message-ID: Subject: [geda-user] Patch for geda_sch2sym.bsh To: gEDA User List Content-Type: multipart/mixed; boundary=089e0112bec8c10a9404da929e7e Reply-To: geda-user AT delorie DOT com --089e0112bec8c10a9404da929e7e Content-Type: text/plain; charset=UTF-8 Hi all, I was trying out the schematic to symbol generator created by Andrew, and i found two small issues: 1. The regex based compares (line ~255) needed the quotes removed - else they always evaluate to false. 2. The name check for IO devices (Line 437) - The original check was case sensitive, changed it to insensitive. SPICE is case insensitive anyway. The patch is attached. Your comments please! Thanks, ~Abhijit Ref: https://bugs.launchpad.net/geda/+bug/698670 --089e0112bec8c10a9404da929e7e Content-Type: application/octet-stream; name="geda_sch2sym.bsh.patch" Content-Disposition: attachment; filename="geda_sch2sym.bsh.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfmu18vj0 LS0tIGdlZGFfc2NoMnN5bS5ic2gJMjAxMy0wNC0xNyAyMzo1NDozOC4wMDAwMDAwMDAgKzA1MzAK KysrIHMycwkyMDEzLTA0LTE3IDIzOjU0OjM1LjAwMDAwMDAwMCArMDUzMApAQCAtMjUxLDEyICsy NTEsMTQgQEAKIAkjIFJlYWQgdXNlciBjb25maWcgZmlsZSB0byBvYnRhaW4gdXNlciBwcmVmZXJl bmNlCiAJd2hpbGUgcmVhZCBsaW5lOyBkbyB7CiAJCSMgU2tpcCBibGFuayBhbmQgY29tbWVudCBs aW5lcyB3aGljaCBiZWdpbiB3aXRoICMgb3IgOwotCQlpZiBbWyAkbGluZSA9fiAiXlwjLioiIHx8 ICRsaW5lID1+ICJeXDsuKiIgfHwgJGxpbmUgPX4gIl4kIiBdXTsgdGhlbgorCQlpZiBbWyAkbGlu ZSA9fiBeXCMuKiB8fCAkbGluZSA9fiBeXDsuKiB8fCAkbGluZSA9fiBeJCBdXTsgdGhlbgorCQog CQkJY29udGludWUKIAkJZmkKIAkJIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiAJCSMgTG9vayBmb3IgW3h4eF0gc2VjdGlvbgotCQlpZiBbWyAiJGxp bmUiID1+ICJeXFsuKlxdIiBdXTsgdGhlbgorCQlpZiBbWyAiJGxpbmUiID1+IF5cWy4qXF0gXV07 IHRoZW4KKwkKIAkJCSMgRm91bmQgYSBbeHh4XSBoZWFkZXIgaW4gZmlsZSwgZXh0cmFjdCBpdHMg bmFtZQogCQkJRlNlY3RfTmFtZT0oYGVjaG8gJGxpbmUgfCBzZWQgLWUgJ3MvXFsvLycgLWUgJ3Mv XF0vLydgKQogCQkJZm91bmRfc2VjdD0wOyBMaT0wCkBAIC00MzcsNyArNDM5LDExIEBACiAJCQlm b3IgKChpPTA7IGkgPCBpb2NudDsgaSsrKSk7IGRvCiAJCQkJdG1wX0E9KCAke3NjaF9JT19kZXZp Y2VzQVskaV19ICkKIAkJCQl0bXBfZGV2X25hbWU9JHt0bXBfQVswXX0KLQkJCQlpZiBbWyAiJGRl dl9uYW1lIiA9PSAiJHRtcF9kZXZfbmFtZSIgXV07IHRoZW4KKwkJCQkKKwkJCQlkZXZfbmFtZV9s Yz1gZWNobyAkZGV2X25hbWUgfCB0ciAnWzp1cHBlcjpdJyAnWzpsb3dlcjpdJ2AKKwkJCQl0bXBf ZGV2X25hbWVfbGM9YGVjaG8gJHRtcF9kZXZfbmFtZSB8IHRyICdbOnVwcGVyOl0nICdbOmxvd2Vy Ol0nYAorCQkJCQorCQkJCWlmIFtbICIkZGV2X25hbWVfbGMiID09ICIkdG1wX2Rldl9uYW1lX2xj IiBdXTsgdGhlbgogCQkJCQlTcmVmZGVzPSR7UmVhZExpbmVBWzBdfQogCQkJCQlwaW50eXBlPSR7 dG1wX0FbMV19CiAJCQkJCXBvc2l0PSR7dG1wX0FbMl19Cg== --089e0112bec8c10a9404da929e7e--