X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Cam-AntiVirus: no malware found
X-Cam-SpamDetails: not scanned
X-Cam-ScannerInfo: http://www.ucs.cam.ac.uk/email/scanner/
Message-ID: <1358792622.4116.5.camel@pcjc2lap.cheyneydesign.local>
Subject: Re: [geda-user] Git repository for sedrename
From: Peter Clifton <peter DOT clifton AT clifton-electronics DOT co DOT uk>
To: geda-user AT delorie DOT com
Date: Mon, 21 Jan 2013 18:23:42 +0000
In-Reply-To: <87hamaz9l8.fsf@gmail.com>
References: <87hamaz9l8 DOT fsf AT gmail DOT com>
Organization: Clifton Electronics
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.6.2-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: "Peter C.J. Clifton" <pcjc2 AT hermes DOT cam DOT ac DOT uk>
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Mon, 2013-01-21 at 13:15 -0500, Ben Gamari wrote:
> Relatively recently I stumbled upon Peter Clifton's sedrename plugin for
> pcb which he brought to the geda-dev list sometime in 2008. Sadly, the
> plugin had severely bit-rotted since it was introduced. Being unable to
> find anyone who had brought the code up to date with the current state
> of pcb, I tossed the file into a Git repository[1], ported it forward,
> and wrote a hacky Makefile. In addition to a rule to build the plugin,
> the Makefile also includes a simple install rule.
> 
> While I didn't change the user interface, it could probably do with some
> revision. It appears that originally the intention was to pass the
> regular expression as an argument to the sedrename command. Is there a
> reason this was #if 0'd in favor of prompt_for()'ing?
> 
> I hope this is useful to someone. As always, pull requests are very
> welcome.


Cool, thanks!

I tend to write those little bits of code as and when I need something
slightly esoteric, and in this case, I think it was for a hierarchical
design I was working on renaming some parts of.

As for why the #if 0 code, I can't remember, sorry. It might have been
as simple as lack of support for quoting the regex properly in the
action string. (I can't recall exactly how our action parser handles
quotes and / or escaping).

Best regards,

-- 
Peter Clifton <peter DOT clifton AT clifton-electronics DOT co DOT uk>

Clifton Electronics