X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com From: John Doty Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: multipart/alternative; boundary=Apple-Mail-117--39302502 Subject: Re: [geda-user] libgeda circle parsing Date: Wed, 16 Jan 2013 14:41:43 -0700 In-Reply-To: To: geda-user AT delorie DOT com References: Message-Id: <57B44348-7A53-4743-8A60-7C9D31EFD1ED@noqsi.com> X-Mailer: Apple Mail (2.1085) Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk --Apple-Mail-117--39302502 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On Jan 16, 2013, at 1:23 PM, Antonio Todo Bom =E2=9C=88 wrote: > I don't know if I'm right, but analysing the code at o_circle_basic.c, = I found: >=20 >=20 > if (radius <=3D 0) { > s_log_message(_("Found a zero or negative radius circle [ %c %d %d = %d %d ]\n"), > type, x1, y1, radius, color); > s_log_message (_("Setting radius to 0\n")); > radius =3D 0; > } >=20 >=20 > If the routine certifies that circle has not a null or negative = radius, why it adjusts it to zero? Couldn't be better to adjust to any = non zero standard value, to turn the object more visible at the design? Well, for consistency a zero radius circle should render as a point at = display resolution, since for larger radii it renders as a curve at = display resolution. Unfortunately, that doesn't seem to happen. But what = if the user actually wants to draw a point? Other objects of zero size are more useful, even though gEDA complains = about them. Why should a script that generates invisible attributes have = to fill in a size? A zero length pin allows the user to express = connections without associated straight lines, e.g. as a circle with a = connecting point at the center. John Doty Noqsi Aerospace, Ltd. http://www.noqsi.com/ jpd AT noqsi DOT com --Apple-Mail-117--39302502 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
I don't know if I'm right, but analysing = the code at o_circle_basic.c, I = found:


  if (radius <=3D = 0) {
    s_log_message(_("Found a zero or negative = radius circle [ %c %d %d %d %d ]\n"),
                  = type, x1, y1, radius, color);
    s_log_message = (_("Setting radius to 0\n"));
    radius =3D = 0;
  = }


  If the routine = certifies that circle has not a null or negative radius, why it adjusts = it to zero? Couldn't be better to adjust to any non zero standard value, = to turn the object more visible at the design?

Well, for consistency a zero = radius circle should render as a point at display resolution, since for = larger radii it renders as a curve at display resolution. Unfortunately, = that doesn't seem to happen. But what if the user actually wants to draw = a point?

Other objects of zero size are more = useful, even though gEDA complains about them. Why should a script that = generates invisible attributes have to fill in a size? A zero length pin = allows the user to express connections without associated straight = lines, e.g. as a circle with a connecting point at the = center.

John Doty              Noqsi = Aerospace, Ltd.

http://www.noqsi.com/

jpd AT noqsi DOT com

= --Apple-Mail-117--39302502--