X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=u74qENj7kOSFxTHN7ESdmPk4CCtdm2d1paYsS4qVLLE=;
        b=cXBLUHCw/k02ku56v7sazNmen4dUDvmWosfF05nVaav3pwqo2lopJL99P95XcOMKg8
         eEAK/bsOItN2BaV8cOaSLEWgw9p6Wohq+IFkZcBxJf2P63nf2dV6n45YaYc9qVBRKG8N
         niYZhl0puPKvq7x0CWRmgby8BnCM8cUzq5pIrKCM3J/jJUx9rY4DL2+uwshiHDoL7mfQ
         H3AgBLndUTPKnifk0oOKBXrCVi4gD4M5y6pg+FNpZN8FTIWMZu5zc4nxk4GDVKg11pGh
         JKPZEabOvWPV4Z8tV4Nl7qyRUK77Hdj2NgjMuYDX/0pkuaduhsx9qLZzqd/hLL3xMu7X
         ruxA==
MIME-Version: 1.0
In-Reply-To: <20121118155051.F0E4B813BDA2@turkos.aspodata.se>
References: <20121113211401 DOT 20747813A49B AT turkos DOT aspodata DOT se>
	<CAOuGh89nhtaPkKZ+0CJGn9V_XnZyi6YD-NndT53FHoAyYD0LFw AT mail DOT gmail DOT com>
	<20121115210903 DOT 90A4881345E3 AT turkos DOT aspodata DOT se>
	<CAPYb0EE-xqA681-iq9AwnL7Wq1j9NL7AP383X5qe5QeCZZW0Ug AT mail DOT gmail DOT com>
	<20121116135510 DOT 6D56B81345EB AT turkos DOT aspodata DOT se>
	<CAOuGh8_tCu_CM=RCRPDAoJMObszqWpjG29-37rAUAHyBN18uSw AT mail DOT gmail DOT com>
	<20121116204345 DOT 9377B81345F9 AT turkos DOT aspodata DOT se>
	<CAOuGh88CA2c+HNu+9QqGZZ2oLSeNHq5bsgvcWDqhQ+5nB_aAbg AT mail DOT gmail DOT com>
	<20121116222416 DOT 4B63C81345FC AT turkos DOT aspodata DOT se>
	<20121118123027 DOT 272B08134615 AT turkos DOT aspodata DOT se>
	<CAPYb0EFmbs-xqhgCfwbPuB-gMc+CTO1fv2ESZkUX5u_5WgSnNA AT mail DOT gmail DOT com>
	<20121118155051 DOT F0E4B813BDA2 AT turkos DOT aspodata DOT se>
Date: Sun, 18 Nov 2012 16:22:54 -0500
Message-ID: <CAPYb0EGU+8Ns7vCro9S3+hjy1jpe0fZH_tPbreesADqFkBT_oQ@mail.gmail.com>
Subject: Re: [geda-user] Bug #903129 Translations don't work on Windows
From: Bob Paddock <bob DOT paddock AT gmail DOT com>
To: geda-user AT delorie DOT com
Content-Type: text/plain; charset=ISO-8859-1
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Sorry, don't have MS-Windows.

Nothing to be sorry about.  Maybe some day we will have a Windows free world...


> on debian. But I don't have any crosscompiled glib, so both fails.

minipack should pull in all the required libraries.

DJ, is the scripts that build the daily windows snapshots someplace public?



>> > Which version of get_locale() do you like, should we use?
>
> Maybe it should be called get_localedir() instead.

get_localedir() would be better here, get_locale() could mean
something besides dir().


> Not strncpy(), but it might not '\0' terminate the string.

That was my point, that is what leads to the potential of buffer overflows.
Depends on what the caller does with the returned string.

> I don't really care as long as it does its job and runs on all
> MS-Windows versions that libgeda targets (even in the future
> hopefully).
>
> Which one of:
>
> 1,
>  GetModuleHandle()
>  GetModuleFileName()
>
> 2,
>  g_win32_get_package_installation_directory_of_module()
>
> will be deprecated first, what do you think?

I expect two will change first based on history.
As there are many other glib dependencies go for it anyway.