X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com Message-ID: <50A1F2A9.4090500@xs4all.nl> Date: Tue, 13 Nov 2012 08:11:37 +0100 From: Bert Timmerman User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.19) Gecko/20110429 Fedora/2.0.14-1.fc13 SeaMonkey/2.0.14 MIME-Version: 1.0 To: geda-user AT delorie DOT com Subject: Re: [geda-user] RFC: storing cursor position in PCB files References: <508BBF8D DOT 5070309 AT jump-ing DOT de> <509B51BE DOT 3010203 AT xs4all DOT nl> <509C7380 DOT 2090008 AT ecosensory DOT com> <1352749309 DOT 10421 DOT 15 DOT camel AT localhost> <20121113002422 DOT 27378 DOT qmail AT stuge DOT se> <1352770711 DOT 9720 DOT 6 DOT camel AT localhost> <20121113015303 DOT 2988 DOT qmail AT stuge DOT se> <1352774294 DOT 9720 DOT 11 DOT camel AT localhost> In-Reply-To: <1352774294.9720.11.camel@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by XS4ALL Virus Scanner Reply-To: geda-user AT delorie DOT com Peter Clifton wrote: > On Tue, 2012-11-13 at 02:53 +0100, Peter Stuge wrote: > > >> I'm in favor of Bert's patch, sans the PCB_FILE_VERSION change. Would >> you like me to fix it up and post somewhere? (Email, git: or http: ?) >> > I think Bert has commit access, and from the sounds of the consensus.. > we'd be all happy if he committed an amended patch. > > It "might" be nice to note in the parse_y.y file where the file-format > documentation is located, that this information is not saved / used by > PCB any more. > > > At some point (presumably coinciding with another major format change), > we might even consider removing the code to read the cursor directive. > > We might already be in a position where we can stub out the parsing code > to be a NOP, and (perhaps) print a warning if the deprecated option is > encountered. > > Personally.. I think not bothering with the latter is a better plan - as > I don't want users to get warnings for _every_ existing PCB file out > there in the world. We can worry about deprecating it later if that > becomes desirable. > > > Bert.. would you mind updating your patch to remove the file format > version number bump, and push it to the upstream repository? > > Best wishes, > > Hi Peter, Amended and pushed the patch, still in the topic branch. I let it sit there for a couple of days and if there is no comments I push it to master. Kind regards, Bert Timmerman.