X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Envelope-From: paubert AT iram DOT es
Date: Sat, 15 Sep 2012 12:51:44 +0200
From: Gabriel Paubert <paubert AT iram DOT es>
To: kmk AT familieknaak DOT de, gEDA user mailing list <geda-user AT delorie DOT com>
Cc: geda-user AT seul DOT org
Subject: [geda-user] [PATCH] fix PostScript headers (was: gschem command line printing)
Message-ID: <20120915105144.GA19447@visitor2.iram.es>
References: <1310451080 DOT 87097 DOT YahooMailClassic AT web39503 DOT mail DOT mud DOT yahoo DOT com>
 <ivilg9$qc1$1 AT dough DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ivilg9$qc1$1@dough.gmane.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-SPF-Received: 2
X-Spamina-Bogosity: Unsure
X-Spam-Score: -1.4 (-)
X-Spam-Report: Content analysis details:   (-1.4 points)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.4 ALL_TRUSTED            Passed through trusted hosts only via SMTP
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

	Hi,

On Wed, Jul 13, 2011 at 01:31:20AM +0200, Kai-Martin Knaak wrote:
> I attached a shellscript for command line printing. It usess the 
> print.scm distributed by geda to output all sheets of a hierarchical 
> design. Output format is a single multi page PDF document. The current 
> date is appended to the file name.

The mailing list has moved in the meantime, but I started using this
script a few days ago. Thank you very much for the script, I'm modifying
it a bit to suit my needs but it was a nice starting point. 

> The script needs some tools that should be part of every linux distro:
> (awk, psmerge and ps2pdf)

Instead of psmerge (which forgot the orientation in the process), I tried
to use psjoin and hit a bug. Not a big deal, it is a single character
bug: psjoin parses the PostScript files and gets confused by a bad
keyword. Here is the one-liner (actually single character) patch, 
EndComments needs an uppercase 'C'.

Could someone please check it in?

Or should I ask for an account to commit trivial patches like this one?

For larger patches, I would always first start a thread on the mailing list,
but for that one, it has taken me more time to write this message than
to write and test the patch!


diff --git a/libgeda/src/f_print.c b/libgeda/src/f_print.c
index d58f04e..688dae8 100644
--- a/libgeda/src/f_print.c
+++ b/libgeda/src/f_print.c
@@ -139,7 +139,7 @@ int f_print_header(TOPLEVEL *toplevel, PAGE *page, FILE *fp,
 	  "%%%%BoundingBox: %d %d %d %d\n"
 	  "%%%%Orientation: %s\n"
 	  "%%%%Pages: 1\n"
-	  "%%%%Endcomments\n"
+	  "%%%%EndComments\n"
 	  "%%%%BeginProlog\n",
 	  PACKAGE_GIT_VERSION,
 	  ctime(&current_time),

	Regards,
	Gabriel