X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Mon, 3 Sep 2012 16:24:03 -0700
From: Larry Doolittle <ldoolitt AT recycle DOT lbl DOT gov>
To: geda-user AT delorie DOT com
Subject: [geda-user] pcbdiff
Message-ID: <20120903232403.GA19048@recycle.lbl.gov>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="T4sUOijqQbZv57TR"
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Reply-To: geda-user AT delorie DOT com


--T4sUOijqQbZv57TR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi -

I messed around some with pcbdiff.  When it works, it's really nice!
But I had problems with the image sizes mismatching between versions,
even though the actual board size didn't change.  Those problems went
away when I took out the --only-visible flag.

While I was in there, I made the 200 dpi default over-ride-able with
the environment variable PCBDIFF_DPI.  Patch attached.

   - Larry

--T4sUOijqQbZv57TR
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="0001-pcbdiff-improvements.patch"

From 62881592de4584fb9da601c994ca5f4424efefb5 Mon Sep 17 00:00:00 2001
From: Larry Doolittle <ldoolitt AT recycle DOT lbl DOT gov>
Date: Mon, 3 Sep 2012 16:20:34 -0700
Subject: [PATCH] pcbdiff improvements

Take out --only-visible
Add PCBDIFF_DPI
---
 tools/pcbdiff |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/pcbdiff b/tools/pcbdiff
index 00378cd..eaa0794 100755
--- a/tools/pcbdiff
+++ b/tools/pcbdiff
@@ -51,8 +51,8 @@ LEFTBNW=`mktemp --tmpdir pcbdiff.XXXXXXXXXX`
 RIGHTBNW=`mktemp --tmpdir pcbdiff.XXXXXXXXXX`
 DIFFPNG=`mktemp --tmpdir pcbdiff.XXXXXXXXXX`
 
-pcb -x png --dpi 200 --only-visible --photo-mode --outfile $LEFTPNG $LEFTFILE
-pcb -x png --dpi 200 --only-visible --photo-mode --outfile $RIGHTPNG $RIGHTFILE
+pcb -x png --dpi ${PCBDIFF_DPI:-200} --photo-mode --outfile $LEFTPNG $LEFTFILE
+pcb -x png --dpi ${PCBDIFF_DPI:-200} --photo-mode --outfile $RIGHTPNG $RIGHTFILE
 convert -colorspace gray $LEFTPNG $LEFTBNW
 convert -colorspace gray $RIGHTPNG $RIGHTBNW
 composite -stereo 0 $LEFTBNW $RIGHTBNW $DIFFPNG
-- 
1.7.2.5


--T4sUOijqQbZv57TR--