X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Thu, 30 Aug 2012 13:26:24 -0700
From: Larry Doolittle <ldoolitt AT recycle DOT lbl DOT gov>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] couple of patches
Message-ID: <20120830202624.GA14617@recycle.lbl.gov>
References: <20120830193343 DOT GA14368 AT recycle DOT lbl DOT gov>
 <20120830200744 DOT GA20825 AT visitor2 DOT iram DOT es>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120830200744.GA20825@visitor2.iram.es>
User-Agent: Mutt/1.5.20 (2009-06-14)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Gabriel -

On Thu, Aug 30, 2012 at 10:07:44PM +0200, Gabriel Paubert wrote:
> On Thu, Aug 30, 2012 at 12:33:43PM -0700, Larry Doolittle wrote:
> > I attach two patches for your consideration.
> 
> > >From aa9ff4abcce5362c8fefc54289a328cd7482a5d2 Mon Sep 17 00:00:00 2001
> > From: Larry Doolittle <ldoolitt AT recycle DOT lbl DOT gov>
> > Date: Thu, 30 Aug 2012 12:10:38 -0700
> > Subject: [PATCH] replace gpleda.org with geda-project.org
> > 
> > ---
> >  ChangeLog             |    7 +++++--
> 
> I might be wrong, but I was convinced that ChangeLog was no
> more updated and that the Right Way (TM) was to write proper
> git commit messages.
> 
> So far, only one commit this year has updated the ChangeLog.
> My opinion on this is writing proper git commit messages is
> necessary and sufficient, duplicating them in a ChangeLog is
> wasteful.

OK.  I noticed the Changelog because of a previous entry
involving domain names.  It would be doubly-wasteful to
undo that change after I made the patch.

The git commit message and the Changelog entry are, not
coincidentally, the same.

> > diff --git a/README b/README
> > index 9b9da9a..54c65cc 100644
> > --- a/README
> > +++ b/README
> > @@ -7,7 +7,7 @@ For additional information read the manual (doc/pcb.pdf)
> >  If you are updating you may wish to read the ChangeLog
> 
> You also need to rewrite this to point people to gitk
> or similar (git log?).

That would be an improvement, yes, but off-topic for this
particular commit (gpleda->geda-project)

   - Larry