X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=penguindevelopment.org; h=
	message-id:date:from:mime-version:to:subject:content-type; q=dns
	; s=penguindevelopment.org; b=tF3gfCh0syUuSj+NgloY3XihD1uKco0S0P
	lXQ8pgaY+n72v8QwuzLdEtGqXBm2rPcKxxlKJ79SmOanAhqs5RjKum4GEAFpdzSB
	Pv9JyjC7An/fOcJhpK7d1B4M7z+dFnZJTTRYbtM6q0c8/r4EvXxuBpoOcvub5az+
	OFIxUeh2Q=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=penguindevelopment.org; h=
	message-id:date:from:mime-version:to:subject:content-type; s=
	penguindevelopment.org; bh=jSYwCziIJRJM11OOkFu6/3wfwCg=; b=XYk6w
	8aDavHIMfWMTlX6BnEWaLX5sUM613UL28iOHZbt+IdboubAPZXa95gAoaGqXW7k4
	utFQR2QT5sJlzspuh0JtEQ7Dxf+Pvt824rShEHapR43pOWPeLp2IWDjixUd5pD/H
	07hFyGbkSMVCNwQqQIVjmvWXMI/RVbFUP+fQTg=
Message-ID: <4FFD25E3.7060508@penguindevelopment.org>
Date: Wed, 11 Jul 2012 09:06:11 +0200
From: Link <link AT penguindevelopment DOT org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120614 Thunderbird/10.0.5
MIME-Version: 1.0
To: geda-user AT delorie DOT com
Subject: [geda-user] geda-gaf: glib includes cause compile failure
Content-Type: multipart/mixed;
 boundary="------------090900040009060304080606"
Reply-To: geda-user AT delorie DOT com

This is a multi-part message in MIME format.
--------------090900040009060304080606
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

libgeda/src/s_path.c includes some system headers from the 
glib-directory. Recent versions of glib apparently demand that you only 
include glib.h directly; doing otherwise causes compilation to fail with 
the message '#error "Only <glib.h> can be included directly."'.

I've attached a patch against git HEAD that fixes it (for me, anyway). 
Curiously, the files that include <glib/gstdio.h> do not need to be 
edited, and as far as I can tell, gstdio.h isn't actually included by 
any of glib's own headers, so I've left that for now.

Peter

--------------090900040009060304080606
Content-Type: text/x-patch;
 name="geda-gaf-glib-include.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="geda-gaf-glib-include.patch"

diff --git a/libgeda/src/s_path.c b/libgeda/src/s_path.c
index 794ff75..dea92f1 100644
--- a/libgeda/src/s_path.c
+++ b/libgeda/src/s_path.c
@@ -37,9 +37,7 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include <glib/gmem.h>
-#include <glib/gmessages.h>
-#include <glib/gtypes.h>
+#include <glib.h>
 
 #include "libgeda_priv.h"
 

--------------090900040009060304080606--