X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Sat, 7 Jul 2012 21:27:20 -0700
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] [PATCH] Allow to create metric Gerber and drill
 files, hopefully final version.
Message-ID: <20120708042719.GE1637@malakian.lan>
References: <20120703140236 DOT GA12646 AT visitor2 DOT iram DOT es>
 <CAKakQcdTgG6E2h+UgWoh-ujP6vFDH=voY-PBJR3OFG2awqL0_A AT mail DOT gmail DOT com>
 <20120705101614 DOT GA19974 AT visitor2 DOT iram DOT es>
 <20120706202633 DOT GA28355 AT malakian DOT lan>
 <20120706213340 DOT GA30622 AT visitor2 DOT iram DOT es>
 <20120707104156 DOT 17641 DOT qmail AT stuge DOT se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120707104156.17641.qmail@stuge.se>
User-Agent: Mutt/1.5.20 (2009-12-10)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Sat, Jul 07, 2012 at 12:41:56PM +0200, Peter Stuge wrote:
> Gabriel Paubert wrote:
> > @@ -668,7 +695,7 @@ gerber_set_layer (const char *name, int group, int empty)
> >  	    }
> >            /* Notice the last zeroes are literal zeroes here, a  *
> >             *  x10 scale factor.  v        v                     */
> > -          pcb_fprintf (f, "X%06.0ml0Y%06.0ml0\r\n",
> > +	  pcb_fprintf (f, metric ? "X%06.0muY%06.0mu\r\n" : "X%06.0ml0Y%06.0ml0\r\n",
> >  		   gerberDrX (PCB, pending_drills[i].x),
> >  		   gerberDrY (PCB, pending_drills[i].y));
> 
> It seems there is a whitespace error in this hunk.
>

Nope, it was actually the old whitespace that was wrong, hence
the funny-looking patch.

However, the v's above are supposed to point to the extra 0's
on the imperial string, which I fixed. That is the only change
I made before pushing the patch.



It is commit e4f7e6158. Thanks Gabriel!

 

-- 
Andrew Poelstra
Email: asp11 at sfu.ca OR apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew
"You shouldn't trust every quote you read on the Internet." -- Socrates