X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Envelope-From: paubert AT iram DOT es
Date: Fri, 6 Jul 2012 22:53:41 +0200
From: Gabriel Paubert <paubert AT iram DOT es>
To: geda-user AT delorie DOT com
Subject: Re: [RFC, v2] [geda-user] [PATCH] Allow to create metric Gerber
 and drill files.
Message-ID: <20120706205341.GA22747@visitor2.iram.es>
References: <20120703140236 DOT GA12646 AT visitor2 DOT iram DOT es>
 <CAKakQcdTgG6E2h+UgWoh-ujP6vFDH=voY-PBJR3OFG2awqL0_A AT mail DOT gmail DOT com>
 <20120705101614 DOT GA19974 AT visitor2 DOT iram DOT es>
 <20120706202633 DOT GA28355 AT malakian DOT lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120706202633.GA28355@malakian.lan>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-SPF-Received: 2
X-Spamina-Bogosity: Unsure
X-Spam-Score: -4.4 (----)
X-Spam-Report: Content analysis details:   (-4.4 points)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-1.8 ALL_TRUSTED            Passed through trusted hosts only via SMTP
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0050]
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Fri, Jul 06, 2012 at 01:26:33PM -0700, Andrew Poelstra wrote:
> On Thu, Jul 05, 2012 at 12:16:14PM +0200, Gabriel Paubert wrote:
> > @@ -765,15 +793,16 @@ gerber_set_layer (const char *name, int group, int empty)
> >  #endif
> >  
> >        fprintf (f, "G04 Format: Gerber/RS-274X *\r\n");
> > -      pcb_fprintf (f, "G04 PCB-Dimensions: %.0mc %.0mc *\r\n",
> > +      pcb_fprintf (f, metric ? "G04 PCB-Dimensions (mm): %.2mm %.2mm *\r\n",
> 
> This line should end in ':', not ','.

Yes, I made the diff before test-compiling and fixing it. Final patch coming soon,
restoring defaults to imperial. 

Then I shall work on the questionable drill numbering.

	Gabriel