X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com Date: Mon, 28 May 2012 14:14:20 -0700 From: Andrew Poelstra To: geda-user AT delorie DOT com Subject: Re: [geda-user] extra mask, plating, and silk colours in pcb Message-ID: <20120528211420.GC16992@malakian.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Mon, May 28, 2012 at 03:55:57PM -0500, Benjamin Bergman wrote: > Last week I was working on a project and I wanted to get my silk screen > looking right, but the photo-realistic options didn't match the fab house I > wanted to use, so I patched pcb to have some options. You can find the > patch here. https://bugs.launchpad.net/pcb/+bug/1004796 > The code is well-written and the patches are a readable size, which are excellent. However, I worry about the UI: 1. There are only a fixed set of colors, which limits the user, and requires us (you) to hardcode color values. Maybe we want to accept hex values instead? 2. What about changing the other colors? I see that you added options for gold-plating and black silk (which IMHO are worthwhile special cases anyway). Maybe we should accept hex values for silk and plate colors as well? Oh, and one other thing -- take a look at "git rebase -i", which lets you interactively rebase and fix things like indendation without creating a new commit. > It is my first patch for pcb, so let me know if there is anything I should > improve. I imagine that marking it as affecting you will also increase the > odds of it being included into the trunk. :) Nope, informing the mailing list (as you did) will increase your odds :). Things often get missed on the bugtracker. -- Andrew Poelstra Email: asp11 at sfu.ca OR apoelstra at wpsoftware.net Web: http://www.wpsoftware.net/andrew "You shouldn't trust every quote you read on the Internet." -- Socrates