Sender: Richard Barlow <skkinny AT gmail DOT com>
Subject: Re: [geda-user] pcb lockup with =?UTF-8?Q?=E2=80=9CClick?= on zoom
 =?UTF-8?Q?focus=E2=80=9D?= prompt in status bar
From: Richard Barlow <richard AT richardbarlow DOT co DOT uk>
To: geda-user AT delorie DOT com
In-Reply-To: <1329384744.5973.10.camel@localhost>
References: <20120121222908 DOT 62d478bc AT svelte>
	 <20120122073620 DOT 30201 DOT qmail AT stuge DOT se> <20120122011323 DOT 68bf4304 AT svelte>
	 <20120215140919 DOT 74be988c AT svelte>  <1329384744 DOT 5973 DOT 10 DOT camel AT localhost>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-XAt8gznFMpEde3TLalZe"
Date: Thu, 16 Feb 2012 17:39:58 +0000
Message-ID: <1329413998.2332.14.camel@richpc>
Mime-Version: 1.0
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
Precedence: bulk


--=-XAt8gznFMpEde3TLalZe
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Peter Clifton wrote:
> It sounds like this bug:
>=20
> https://bugs.launchpad.net/bugs/699309
> ...
> I've not got time to look at this in the short term, but I don't think
> it would be much work to fix now we have a complete description of how
> to reproduce the bug on demand.

I've just posted a patch that I think solves the issue. As I've said in
the comments, it seems to stem from the code that gets a coord when the
cursor isn't over the layout (run_get_location_loop in
src/hid/gtk/gui-misc.c) being called multiple times.

Peter Stuge <peter AT stuge DOT se> wrote:
> > It's somehow reproducible also without a scrollwheel. With default
> > config just press z or shift-z while the mouse pointer is anywhere
> > outside the layout but still within the pcb window. Using GTK.

Colin D Bennett wrote:
> That doesn't lock it up for me.  If I hit 'z' with the mouse over,
> for instance, the layers palette (or title bar, status bar, etc.),
> I get the prompt in the status bar and the disabled interface
> features, but when I click the layout pcb returns to normal mode.

=46rom looking at the code this is what I'd expect to happen. The first
call to run_get_location_loop will disable the UI and intercept any more
keyboard key and mouse button events. Pressing 'z' is equivalent to
scrolling one step (described in the bug comments). Pressing 'z' twice
will exit run_get_location_loop as any keypress other than enter is
treated as an abort.

=46rom what I can tell the disabling of the UI is to prevent multiple
calls to HID commands that potentially require user input to select a
coordinate. I think this was bypassed with the scroll wheel because of
the signal handler not being disconnected.

Rich

--=-XAt8gznFMpEde3TLalZe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAABAgAGBQJPPT9rAAoJEMWwul/B8SCJZD8H+wdPUqJ2FGaaiq8RLlDpfVFj
r8zfm4BuvBqK6lony+p8BOTCKRXrJBE7uDekaS3pJaGB7RUZ3kj/j+/NIyJMSSgJ
OCJ01jvwZBCcDpHNxT/xymmZfZ/2bDXStnbAlHI2LWH6ku7tIpEKHE56NI8h/ffi
t7iTxND8gtysSopoKdJSa6kXgyvSnfT2bxZiVXrIO47chUbb7yYS6QlowKVJswIP
NrXqWO93vYIK6928QxB1eQyh7GByqjo9NXSZAGwiXD175FuZzQ8pHWqa61yIyX22
obn6xg0r/khNameOyIJIhb/oBPaKDtxZvmnhgy/394pwFeCG8FUeGoSqk4sNUKE=
=vuYH
-----END PGP SIGNATURE-----

--=-XAt8gznFMpEde3TLalZe--