On Thu, Jan 2, 2014 at 8:52 AM, Joshua Lansford &= lt;joshu= a DOT lansford AT laserlinc DOT com> wrote:

=A0 I just had a scare, =A0= I was casually checking stuff into svn and noticed in a diffed netlist outp= ut that a component from one of our designs in production was missing a com= ponent. =A0I checked the schematic and the part was there all bright eyed a= nd bushy tailed but it was completely missing from the generated netlist wi= thout any complaint from gnetlist. =A0I took a look at the schematic with v= im and discovered I had a property missing a value. =A0I removed this value= less property and *ding* the component shows back up in the netlist when I = run gnetlist. =A0Checking around some more with diff I discovered there was= another component silently being dropped from the netlist. =A0gnetlist use= to seg fault when there is a missing valued property. =A0Now apparently it= silently assassinates the component.

At first I thought I would just make a check script to = make sure no components are dropped, but then I thought perhaps I might als= o be able to fix gnetlist and further this project. =A0But thought I would = check in with everyone to make sure this isn't like this for a reason o= r perhaps has already been fixed.

~Joshua

The following chang= e fixes the problem:

diff --git a/libgeda/src/o_attr= ib.c b/libgeda/src/o_attrib.c

index 5dae202..cb161a1 100644

--- a/libgeda/src/o_attrib.c

= +++ b/libgeda/src/o_attrib.c

@@ -383,7 +383= ,7 @@ o_attrib_string_get_name_value (const gchar *string, gchar **name_ptr= , gchar **v

=A0 =A0prev_char =3D g_utf8_find_prev_char (stri= ng, ptr);

=A0 =A0next_char =3D g_utf8_find_= next_char (ptr, NULL);

=A0 =A0if (prev_char= =3D=3D NULL || *prev_char =3D=3D ' ' ||

- =A0 =A0 =A0next_char =3D=3D NULL || *next_char= =3D=3D ' ' || *next_char =3D=3D '\0' ) {

+ =A0 =A0 =A0next_char =3D=3D NULL || *next_char =3D=3D &#= 39; ' ) {

=A0 =A0 =A0return FALSE;

=A0 =A0}

I did notice in the comment of the function o_attrib_= string_get_name_value that a valueless attribute is intentionally invalid.<= /div>

=A0* =A0If you get an invalid attribute (improper) with a = name and no

=A0* =A0value, then it is NOT a= n attribute.

What proble= ms would it cause for the library to be tolerant to valueless attributes? = =A0According to this following link, I see that o_attribute_string_get_name= _value intolerance has caused other problems already and resulted in a comm= it having to be reverted because it standardized on this function making th= e code less stable. =A0This seems to indicate to me that valueless attribut= es happen and allowing the code to behave reasonably when they do would ben= efit everything in the long run.

http://archives.seul.org/geda/cvs/Sep-2008/msg00014.ht= ml=A0

I have seen at least one other person in the past who couldn't figu= re out why gnetlist was bombing until they figured out they had had a value= less attribute.=A0

Can this be= discussed?

Thanks,

~Joshua

--047d7bd6b9ac0400fe04ef003e84--