X-Authentication-Warning: delorie.com: mail set sender to geda-help-bounces using -f
X-Recipient: geda-help AT delorie DOT com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=date:from:to:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        bh=Hkjme/Nohxm1rI64ictfX8TOD4wFtIMt4zhKoRYR8Ds=;
        b=RL1ghtm20lPMrZg8acQ69lN1jEK0wRZopilFVVV6MtBW9q9HW+QZ62chJ9j1KC6NPS
         ts3fEGRDII2bi1eLt2941dnYNyJ0LlQyW46eHDIOFb+ka0/aSqdGaOjawdow4D0v3PaY
         s2vyDoUITaFY3vt83CvxxEejpQAj1UnQM0REw=
Date: Wed, 14 Dec 2011 00:33:15 +0400
From: Vladimir Zhbanov <vzhbanov AT gmail DOT com>
To: geda-help AT delorie DOT com
Subject: Re: [geda-help] gnetlist & TwoStageAmp problems
Message-ID: <20111213203315.GA32449@localhost.localdomain>
Mail-Followup-To: geda-help AT delorie DOT com
References: <20111212205855 DOT GA27945 AT localhost DOT localdomain>
 <acc7a16619c887610143a9f582b9cb27 AT mail DOT theimps DOT com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="wRRV7LY7NUeQGEoC"
Content-Disposition: inline
In-Reply-To: <acc7a16619c887610143a9f582b9cb27@mail.theimps.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Reply-To: geda-help AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-help AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


--wRRV7LY7NUeQGEoC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Dec 12, 2011 at 10:34:56PM +0000, Peter TB Brett wrote:
...
> 
> I've now pushed a fix for this. :-)  Thanks for the report!
> 
> Peter
> 

Nice patch :) Thanks.

I have two 'big' patches, too. In doubt, whether to load them to
bug-tracker :) (See attachment.)

-- 
VZh
http://vzhbanov.byethost33.com

--wRRV7LY7NUeQGEoC
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="0001-Fixed-incorrectly-formed-list-for-stroke-Z.patch"

From 33a195e8031ce4d7c31f17cc8efa58fb9bdd04a7 Mon Sep 17 00:00:00 2001
From: Vladimir Zhbanov <vzhbanov AT gmail DOT com>
Date: Tue, 13 Dec 2011 23:38:49 +0400
Subject: [PATCH 1/2] Fixed incorrectly formed list for stroke Z

---
 gschem/lib/system-gschemrc.scm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gschem/lib/system-gschemrc.scm b/gschem/lib/system-gschemrc.scm
index 59a7ec9..bcbab7c 100644
--- a/gschem/lib/system-gschemrc.scm
+++ b/gschem/lib/system-gschemrc.scm
@@ -1058,7 +1058,7 @@
 ("125789" . view-zoom-box)
 ("1254789" . view-zoom-box)
 ("1235789" . view-zoom-box)
-("2354789" .view-zoom-box)
+("2354789" . view-zoom-box)
 ("2324789" . view-zoom-box)
 ("12354789" . view-zoom-box)
 ("12324789" . view-zoom-box)
-- 
1.7.7.3


--wRRV7LY7NUeQGEoC
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="0002-Fixed-debug-output-and-some-typos-in-comments-of-spi.patch"

From a23bf5d0ff846be34b57ff4aab9c834f9aa0533b Mon Sep 17 00:00:00 2001
From: Vladimir Zhbanov <vzhbanov AT gmail DOT com>
Date: Wed, 14 Dec 2011 00:02:09 +0400
Subject: [PATCH 2/2] Fixed debug output and some typos in comments of
 spice-sdb backend

---
 gnetlist/scheme/gnet-spice-sdb.scm |   32 ++++++++++++++++----------------
 1 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/gnetlist/scheme/gnet-spice-sdb.scm b/gnetlist/scheme/gnet-spice-sdb.scm
index 593adea..3193a5b 100644
--- a/gnetlist/scheme/gnet-spice-sdb.scm
+++ b/gnetlist/scheme/gnet-spice-sdb.scm
@@ -93,9 +93,9 @@
 ;;              write-net-names-on-component to make it a bit more flexible.
 ;;              Combine write-probe-item and write-net-names-on-component.  Add
 ;;              a range utility function.  CC
-;;  1.13.2011 -- Add four lines of code (and some comments) that allow formaitting strings
+;;  1.13.2011 -- Add four lines of code (and some comments) that allow formatting strings
 ;;               to be used for netlisting NGspice device models. CC
-;;  6.12.2011 -- Updated the Problematci name=? symbols to name=unknown and removed the
+;;  6.12.2011 -- Updated the problematic name=? symbols to name=unknown and removed the
 ;;               FIXME check for them. This should be a step closer to place holder consistancy. CC
 ;;
 ;;**********************************************************************************
@@ -152,7 +152,7 @@
 		(list-elt-file-type (caddr list-element))
 	       )
 	  (if (string=? list-elt-model-name model-name)
-	      list-element                                                        ;; found model-name.  Reutrn list-element.
+	      list-element                                                        ;; found model-name.  Return list-element.
 	      (spice-sdb:get-file-info-list-item model-name (cdr file-info-list)) ;; otherwise, recurse.
 	  )
         )  ;; end of let*
@@ -734,12 +734,12 @@
       (spice-sdb:write-component-no-value package port)
 
    ;; next look for "model-name" attribute.  Write it out if it exists.
-   ;; otherwise look for "device" attribute.
+   ;; otherwise look for "value" attribute.
       (if (not (string=? model-name "unknown"))
           (display (string-append model-name " " ) port)  ;; display model-name if known
-          (display (string-append value " ") port))       ;; otherwise display device
+          (display (string-append value " ") port))       ;; otherwise display value
 
-  ;; Next write out attribtes if they exist
+  ;; Next write out attributes if they exist
   ;; First attribute is area.  It is written as a simple string
       (if (not (string=? area "unknown"))
           (display (string-append area " ") port))
@@ -1001,7 +1001,7 @@
 ;;-----------------------------------------------------------
 (define spice-sdb:write-vc-switch
   (lambda (package port)
-    (debug-spew (string-append "Found voltage controled switch.  Refdes = " package "\n"))
+    (debug-spew (string-append "Found voltage controlled switch.  Refdes = " package "\n"))
     (let ((attrib-list (list " " ) ))
       (spice-sdb:write-transistor-diode package "S" "SW" attrib-list port))
   )
@@ -1070,7 +1070,7 @@
 		(display (string-append model-name " " ) port))
     )
 
-    ;; Next write out attribtes if they exist.  Use 
+    ;; Next write out attributes if they exist.  Use
     ;; a list of attributes which can be attached to a capacitor.
     ;; I include non-standard "area" attrib here per request of Peter Kaiser.
     (let ((attrib-list (list "area" "l" "w" "ic")))
@@ -1248,10 +1248,10 @@
 
 
 ;;--------------------------------------------------------------------
-;; Given a refdes and port, and optionaly a format string, this writes
+;; Given a refdes and port, and optionally a format string, this writes
 ;; out the nets attached to the component's pins. If it's not called
 ;; with a format string it looks for one in the net-format attribute,
-;; otherwise it writes out the pins unformated. This is used to write
+;; otherwise it writes out the pins unformatted. This is used to write
 ;; out non-slotted parts.
 ;;--------------------------------------------------------------------
 (define (spice-sdb:write-net-names-on-component refdes port . format)
@@ -1269,7 +1269,7 @@
 	      (debug-spew (string-append "     pinnumber = " (gnetlist:get-attribute-by-pinseq refdes pin "pinnumber") "\n"))
 	      (debug-spew (string-append "     pinseq = " (gnetlist:get-attribute-by-pinseq refdes pin "pinseq")))
 	      (if (not (string=? pin (gnetlist:get-attribute-by-pinseq refdes pin "pinseq")))
-		(debug-spew " <== INCONSISTANT!\n")
+		(debug-spew " <== INCONSISTENT!\n")
 		(debug-spew "\n") )
 	      (debug-spew (string-append "     netname = " (car (spice-sdb:get-net refdes (gnetlist:get-attribute-by-pinseq refdes pin "pinnumber"))) "\n"))
 	  )) ;; if #T for super debugging
@@ -1382,7 +1382,7 @@
 
 ;;----------------------------------------------------------
 ;; Include a file using an .INCLUDE directive
-;; Changed on 6.12.2005: to embedd the contents of the file,
+;; Changed on 6.12.2005: to embed the contents of the file,
 ;; you must call gnetlist with the -e flag set.
 ;;----------------------------------------------------------
 (define spice-sdb:write-include
@@ -1416,7 +1416,7 @@
 	  (if (calling-flag? "embedd_mode" (gnetlist:get-calling-flags))
 	      (begin
 		(spice-sdb:insert-text-file file port)                 ;; -e found: invoke insert-text-file
-		(debug-spew (string-append "embedding contents of " value " into netlist.\n")))
+		(debug-spew (string-append "embedding contents of file " file " into netlist.\n")))
 	      (begin
 		(display (string-append ".INCLUDE " file "\n") port)   ;; -e not found: just print out .INCLUDE card
 		(debug-spew "placing .include directive string into netlist.\n"))
@@ -1538,7 +1538,7 @@
 ;;**********************************************************************************
 
 ;;----------------------------------------------------------------------
-;; write-netlist is passed a list of refdess (ls).  It uses 
+;; write-netlist is passed a list of refdesses (ls).  It uses
 ;; each refdes to get the corresponding
 ;; "device" attribute.  Depending upon the device, it then invokes one or another of the 
 ;; spice line output fcns to output a line of the spice netlist.
@@ -1635,7 +1635,7 @@
 
 
 ;;----------------------------------------------------------------------
-;; create-file-info-list: This takes as arugment the list of packages (refdesses).
+;; create-file-info-list: This takes as argument the list of packages (refdesses).
 ;;   It runs through the package list, and for each gets the attributes.  If there is a
 ;;   "FILE" attribute, it gets the file info & uses it to build the
 ;;   file-info-list.  When done, it returns the file-info-list.
@@ -1782,7 +1782,7 @@
 ;;       attribute.  Every time a "file" attribute is found do this:
 ;;       --  Open the file and find out what kind of file it is (.SUBCKT or .MODEL).
 ;;       --  Determine if the file has previously been processed.  If not: stick the 
-;;           follwing info into the file-info list: (model-name file-name file-type). 
+;;           following info into the file-info list: (model-name file-name file-type).
 ;;           Otherwise just continue.
 ;;   3.  Loop through all components again, and write out a SPICE card for each.  
 ;;   4.  Afterwards, for each item in the file-info list, open the file, and
-- 
1.7.7.3


--wRRV7LY7NUeQGEoC--