X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f X-Recipient: djgpp AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=eKa78HXhSMmiEiNbtft8ETV1/ALan3M/DOR4H5m6DYI=; b=J2R2H4yqqQj+vfr0EaL9ijfjtE6nTqmugEr1T6ifkuqQnBtTr8una/I0Pzi61hTxG9 2ekhRdBoecnLkKujIg4lNbFWlZ1ibninZwKJS2j/ZkAr7kQbI48dyuFpo/evX4Gj/9ul eibEBIl4L68P98K0zmXrUhe1T7VfUFeP6eTBchGIn/oo4s2RP2D+DEwef/Rr/wYpkZy4 2WffTKGxYIZhGaWgANbYLVToYei1i2J4oynVr0dRTFupAXPdem7x0oTqlY4yFeJ1eA+s 8vE+u+hZUjACZvWdBebLYOoGyLAE01OF47R6Fjh7+kTIyuJmcBBm+gagfY2LnvPk3N0D R0Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=eKa78HXhSMmiEiNbtft8ETV1/ALan3M/DOR4H5m6DYI=; b=RJ3rB9jyv1fObH653/P6o98nIAwYvuaHoHD+Fc4QymRg4vWHPD9uD7rdJGJRBmLHTs finEA+Irgma6/YwP6UN+T7dU2r9My+stcq1b66bsyD3alfnoEmtdDH7cQY8bJ3J66+bK du8GdikdPvUf5ToybEH/2UC4UYBB1LOBLGdu2CTmlPV+h9OovUjL9m9uMZdrhLokCBVY 16bFIxfDJlDg4MIUuqV4tw2Z4PRFQilr2LhZqqrrUj7Hvev49GMgJIccr0xGBOT67q84 bzeHTkqQbS+UbTMq+9DtpnTfrtSjmpdpiyUygI2jJDSvb8aCn9irISr/l7FlQoBLAqUY APpQ== X-Gm-Message-State: AEkoout0cG+zkDAOExPoN6bWd7zL9qb7HH0kAX5N1qjcxqVS1dyIghbcNhB6vwuRlEKpAAdEkSJfTp+UTzgpKQ== X-Received: by 10.36.123.139 with SMTP id q133mr5428531itc.10.1469219850619; Fri, 22 Jul 2016 13:37:30 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1dc4b273-bfe4-4d67-8af6-2e293a4fcb58 AT googlegroups DOT com> From: "Ozkan Sezer (sezeroz AT gmail DOT com) [via djgpp AT delorie DOT com]" Date: Fri, 22 Jul 2016 23:37:30 +0300 Message-ID: Subject: Re: LD from binutils 2.26 crashes when -ffunction-sections + -Wl,--gc-sections is used but only under DOS To: djgpp AT delorie DOT com Content-Type: text/plain; charset=UTF-8 Reply-To: djgpp AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On 7/22/16, Ozkan Sezer wrote: > On 7/22/16, RayeR (glaux AT centrum DOT cz) [via djgpp AT delorie DOT com] > wrote: >>> It segs in fini_reloc_cookie_rels() because (sec)->used_by_bfd is NULL >> >> So you mean that it is rather binutils (djgpp coff) generator code >> problem >> than djdev? >> > > Yes. (And why would djdev fail on a dos os?? That would defeat its very > own purpose.) > > The following alternative patch works too, but like before it might be > the wrong way of fixing this. > > diff -urNp binutils-2.26/bfd/coffgen.c.orig binutils-2.26/bfd/coffgen.c > --- binutils-2.26/bfd/coffgen.c.orig 2015-11-13 10:27:40.000000000 +0200 > +++ binutils-2.26/bfd/coffgen.c 2016-07-22 11:41:02.000000000 +0300 > @@ -2688,7 +2688,7 @@ static void > fini_reloc_cookie_rels (struct coff_reloc_cookie *cookie, > asection *sec) > { > - if (cookie->rels && coff_section_data (NULL, sec)->relocs != cookie->rels) > + if (cookie->rels && (!coff_section_data (NULL, sec) || coff_section_data (NULL, sec)->relocs != cookie->rels)) > free (cookie->rels); > } > > I created this bugzilla entry for this issue: https://sourceware.org/bugzilla/show_bug.cgi?id=20401 Hopefully someone looks into it. -- O.S.