X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f X-Recipient: djgpp AT delorie DOT com X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Date: Sun, 12 Jun 2016 20:28:20 +0300 Message-Id: <83y46afhaj.fsf@gnu.org> From: "Eli Zaretskii (eliz AT gnu DOT org) [via djgpp AT delorie DOT com]" To: djgpp AT delorie DOT com CC: bug-make AT gnu DOT org In-reply-to: <575D996C.1000507@gmx.de> (djgpp@delorie.com) Subject: Re: Some DJGPP specific fixes for Make 4.2.1 and later. References: <575D996C DOT 1000507 AT gmx DOT de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e Reply-To: djgpp AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk > Date: Sun, 12 Jun 2016 19:18:36 +0200 > From: "Juan Manuel Guerrero (juan DOT guerrero AT gmx DOT de) [via djgpp AT delorie DOT com]" > > - For systems like MSDOS, WINDOWS32 and other ones, the function get_bad_stdin > is defined as a no-op macro in os.h but at the same time exists an > implementation of the function in posixos.c. This implementation > is always compiled no matter if __MSDOS__ and/or MAKE_JOBSERVER is > defined or not in posixos.c. To avoid this contradiction, I have put > the get_bad_stdin definition inside the same #ifdef than the ones used > in os.h. Please inspect the patch. This approach is only a suggestion; > may be there is a different way to solve this issue. posixos.c is not supposed to be compiled on MSDOS (or any other non-Posix system). Why is it being compiled in the DJGPP build? The other changes look fine to me, thanks.